Can Esc/finish drawing an Area when cursor is in invalid position #4860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just realised that the 'exception' I mentioned above was basically an existing bug (At the moment, if you press Escape after drawing a leading edge that goes around a corner to the 'wrong side', you end up with a self-intersecting area), so this fixes 2-in-one |
- When drawing an Area, the leading edge is allowed to temporarily be in an invalid position (see openstreetmap#4655).. .. Finishing a drawing is disabled if doing so would close with the invalid leading edge
|
Hey @jguthrie100, I just tested it out and it works great - thanks so much for the PR 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4845
Can press Esc/Return when cursor is in invalid position and the drawing will still complete
An exception is made for when the completed Area would be invalid (i.e. when a temporarily invalid leading edge has been made as per #4655 , which cannot be accepted as a valid edge when closing the Area)