-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notes #5107
Commits on Jun 19, 2018
-
Configuration menu - View commit details
-
Copy full SHA for f92bc63 - Browse repository at this point
Copy the full SHA f92bc63View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3c0fd4 - Browse repository at this point
Copy the full SHA e3c0fd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ed915e - Browse repository at this point
Copy the full SHA 1ed915eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3de1fd8 - Browse repository at this point
Copy the full SHA 3de1fd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf2a9ad - Browse repository at this point
Copy the full SHA cf2a9adView commit details
Commits on Jun 20, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 3df01e2 - Browse repository at this point
Copy the full SHA 3df01e2View commit details
Commits on Jun 21, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 473570c - Browse repository at this point
Copy the full SHA 473570cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 47ef49d - Browse repository at this point
Copy the full SHA 47ef49dView commit details -
Configuration menu - View commit details
-
Copy full SHA for db0fe7e - Browse repository at this point
Copy the full SHA db0fe7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4576100 - Browse repository at this point
Copy the full SHA 4576100View commit details -
Configuration menu - View commit details
-
Copy full SHA for e16b411 - Browse repository at this point
Copy the full SHA e16b411View commit details
Commits on Jun 22, 2018
-
Configuration menu - View commit details
-
Copy full SHA for dab46d2 - Browse repository at this point
Copy the full SHA dab46d2View commit details
Commits on Jun 23, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 1878397 - Browse repository at this point
Copy the full SHA 1878397View commit details
Commits on Jun 25, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 0859d00 - Browse repository at this point
Copy the full SHA 0859d00View commit details
Commits on Jun 29, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 737ccfc - Browse repository at this point
Copy the full SHA 737ccfcView commit details
Commits on Jun 30, 2018
-
Configuration menu - View commit details
-
Copy full SHA for b3f7b06 - Browse repository at this point
Copy the full SHA b3f7b06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9517635 - Browse repository at this point
Copy the full SHA 9517635View commit details -
Configuration menu - View commit details
-
Copy full SHA for d034691 - Browse repository at this point
Copy the full SHA d034691View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for fd1d2f0 - Browse repository at this point
Copy the full SHA fd1d2f0View commit details -
Add update method, remove getters..
This makes the osmNote work a bit more like other osm objects in iD. - When working with the osm objects, we'll treat them as immutable. So all modifications will be through the update method: e.g. can do this in a repl, like chrome devtools console: > n = iD.osmNote() osmNote { id: -1 } > n = n.update({ foo: 'bar' }); osmNote { foo: "bar", id: -1, v: 1 } - none of the other osm objects have getters, and in JavaScript all the properties are public anyway
1Configuration menu - View commit details
-
Copy full SHA for ede5610 - Browse repository at this point
Copy the full SHA ede5610View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b06dbd - Browse repository at this point
Copy the full SHA 1b06dbdView commit details -
Cleanup osm service notes and caches, remove state variable
This seems like a lot but the main things here are: - remove the _loadingTiles "global" variable. It was causing problems because it was being checked from the callbacks, which are async. - cleanup the caches - use DOM API getElementsByTagName('id') to get note id - set a lower tilezoom z13 for notes (meaning: fetch larger bounding boxes)
2Configuration menu - View commit details
-
Copy full SHA for 229484a - Browse repository at this point
Copy the full SHA 229484aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f8efee - Browse repository at this point
Copy the full SHA 2f8efeeView commit details -
Configuration menu - View commit details
-
Copy full SHA for eba9bde - Browse repository at this point
Copy the full SHA eba9bdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for dcef114 - Browse repository at this point
Copy the full SHA dcef114View commit details -
Configuration menu - View commit details
-
Copy full SHA for bcc1669 - Browse repository at this point
Copy the full SHA bcc1669View commit details -
- open notes are red (default) - resolved notes are green - orange on hover - yellow on select (also added centerEase to note location)
Configuration menu - View commit details
-
Copy full SHA for f3d31f3 - Browse repository at this point
Copy the full SHA f3d31f3View commit details
Commits on Jul 1, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 487ec9d - Browse repository at this point
Copy the full SHA 487ec9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fc94f5 - Browse repository at this point
Copy the full SHA 9fc94f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc4d800 - Browse repository at this point
Copy the full SHA fc4d800View commit details
Commits on Jul 2, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 00c8ff4 - Browse repository at this point
Copy the full SHA 00c8ff4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 535208b - Browse repository at this point
Copy the full SHA 535208bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 65b2a42 - Browse repository at this point
Copy the full SHA 65b2a42View commit details -
Configuration menu - View commit details
-
Copy full SHA for 13a30c0 - Browse repository at this point
Copy the full SHA 13a30c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3304cc8 - Browse repository at this point
Copy the full SHA 3304cc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b4dde0 - Browse repository at this point
Copy the full SHA 5b4dde0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c22fe0 - Browse repository at this point
Copy the full SHA 2c22fe0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d81b9c5 - Browse repository at this point
Copy the full SHA d81b9c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a474e3b - Browse repository at this point
Copy the full SHA a474e3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 94eae89 - Browse repository at this point
Copy the full SHA 94eae89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86dc0c9 - Browse repository at this point
Copy the full SHA 86dc0c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7999aca - Browse repository at this point
Copy the full SHA 7999acaView commit details -
Configuration menu - View commit details
-
Copy full SHA for bd8705b - Browse repository at this point
Copy the full SHA bd8705bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d2845e - Browse repository at this point
Copy the full SHA 2d2845eView commit details
Commits on Jul 3, 2018
-
Adjust pointer css for note markers
This sets `pointer-events: none` for the `.note-shadow` class, to fix an amusing bug where hovering over the filled part of the comment icon would work ok but hovering over the "dots" would not.
Configuration menu - View commit details
-
Copy full SHA for d87a2c2 - Browse repository at this point
Copy the full SHA d87a2c2View commit details -
Switch
innerHtml
totextContent
, which properly unescapes xmlThis commit also fixes a linter error, and switches some lodash _forEach to normal for loops.
Configuration menu - View commit details
-
Copy full SHA for e0cc626 - Browse repository at this point
Copy the full SHA e0cc626View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab8e793 - Browse repository at this point
Copy the full SHA ab8e793View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4c6607 - Browse repository at this point
Copy the full SHA b4c6607View commit details -
Configuration menu - View commit details
-
Copy full SHA for 61ae541 - Browse repository at this point
Copy the full SHA 61ae541View commit details -
2
Configuration menu - View commit details
-
Copy full SHA for 8121f58 - Browse repository at this point
Copy the full SHA 8121f58View commit details -
resolve conflicts, fix a few minor bugs prob caused by merging:
- don't insert multiple times into the rtree in `services/osm.js` - use `d.id` instead of `d.key` as the key in `svg/notes.js`
Configuration menu - View commit details
-
Copy full SHA for b14d1b5 - Browse repository at this point
Copy the full SHA b14d1b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf499d9 - Browse repository at this point
Copy the full SHA bf499d9View commit details
Commits on Jul 4, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 73ee5c2 - Browse repository at this point
Copy the full SHA 73ee5c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f1dc12 - Browse repository at this point
Copy the full SHA 6f1dc12View commit details
Commits on Jul 5, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 263ec9e - Browse repository at this point
Copy the full SHA 263ec9eView commit details
Commits on Jul 6, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 01b33e3 - Browse repository at this point
Copy the full SHA 01b33e3View commit details
Commits on Jul 7, 2018
-
Configuration menu - View commit details
-
Copy full SHA for d137aa0 - Browse repository at this point
Copy the full SHA d137aa0View commit details
Commits on Jul 8, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 3eb3eef - Browse repository at this point
Copy the full SHA 3eb3eefView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b42743 - Browse repository at this point
Copy the full SHA 7b42743View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f49514 - Browse repository at this point
Copy the full SHA 0f49514View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14356ce - Browse repository at this point
Copy the full SHA 14356ceView commit details
Commits on Jul 9, 2018
-
Configuration menu - View commit details
-
Copy full SHA for c460c03 - Browse repository at this point
Copy the full SHA c460c03View commit details
Commits on Jul 10, 2018
-
Configuration menu - View commit details
-
Copy full SHA for eafae6c - Browse repository at this point
Copy the full SHA eafae6cView commit details
Commits on Jul 11, 2018
-
Refactor out uiNoteHeader and uiNoteComments into separate modules
uiNoteEditor was getting big!
Configuration menu - View commit details
-
Copy full SHA for 0d7c292 - Browse repository at this point
Copy the full SHA 0d7c292View commit details -
Implement multi-fetch get for users from OSM API
Eagerly load user details after loading notes (re: openstreetmap/openstreetmap-website#1921)
Configuration menu - View commit details
-
Copy full SHA for 7423d19 - Browse repository at this point
Copy the full SHA 7423d19View commit details -
Add noteOptions, default to 10k note limit and 7 days closed
Also bump note tile zoom to z12. There just aren't that many notes, so this reduces API calls.
Configuration menu - View commit details
-
Copy full SHA for f52f24b - Browse repository at this point
Copy the full SHA f52f24bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e9e2f9b - Browse repository at this point
Copy the full SHA e9e2f9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3454753 - Browse repository at this point
Copy the full SHA 3454753View commit details
Commits on Jul 12, 2018
-
WIP on buttons, simplify, remove some event dispatch
- I made the buttons work like GitHub comment-on-issue buttons before typing: "Close Note" / "Comment" (disabled) after typing: "Close and Comment" / "Comment" (enabled) - I removed a bunch of the event dispatches. These are useful for sending events to listeners/observers outside of the module. In this case I think we can handle most of the things from within the uiNoteEditor. We can still dispatch an 'update' event so that modeSelectNote can reselect and redraw the note after some change happens to it. TODO - make the buttons work / check the OSM API stuff.
Configuration menu - View commit details
-
Copy full SHA for 91add0c - Browse repository at this point
Copy the full SHA 91add0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e5601f - Browse repository at this point
Copy the full SHA 5e5601fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe7086f - Browse repository at this point
Copy the full SHA fe7086fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 19560eb - Browse repository at this point
Copy the full SHA 19560ebView commit details
Commits on Jul 13, 2018
-
Add docs about OSM API, finish implementing
postNoteUpdate
`postNoteUpdate` can hangle status changes and comment additions (I named it that to be like `putChangeset`) Also renamed `user` to `loadUser` to be consistent with other calls
Configuration menu - View commit details
-
Copy full SHA for 645cc79 - Browse repository at this point
Copy the full SHA 645cc79View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57da729 - Browse repository at this point
Copy the full SHA 57da729View commit details -
Configuration menu - View commit details
-
Copy full SHA for 775b472 - Browse repository at this point
Copy the full SHA 775b472View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a1079c - Browse repository at this point
Copy the full SHA 8a1079cView commit details -
Can't skip seen on the
userDetails
callThis call really does need for a result to be passed to the callback
Configuration menu - View commit details
-
Copy full SHA for f825845 - Browse repository at this point
Copy the full SHA f825845View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd15865 - Browse repository at this point
Copy the full SHA bd15865View commit details -
Wrap callbacks with common checks for connection id and auth failure
This eliminates a lot of the copy-paste code in every callback.
Configuration menu - View commit details
-
Copy full SHA for 33ef9a4 - Browse repository at this point
Copy the full SHA 33ef9a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a106f5 - Browse repository at this point
Copy the full SHA 1a106f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fb42ac - Browse repository at this point
Copy the full SHA 7fb42acView commit details
Commits on Jul 16, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 7ad765d - Browse repository at this point
Copy the full SHA 7ad765dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 33de399 - Browse repository at this point
Copy the full SHA 33de399View commit details -
Before: We drew 2 fontawesome comment icons, on on top of the other After: Moved icon into iD spritesheet and gave it an actual `stroke` property that can be styled
Configuration menu - View commit details
-
Copy full SHA for 70f8763 - Browse repository at this point
Copy the full SHA 70f8763View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47de7b3 - Browse repository at this point
Copy the full SHA 47de7b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 694cc60 - Browse repository at this point
Copy the full SHA 694cc60View commit details