Switch brand suggestion preset generation over to inherit fields #5716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also attempts to use `cuisine` and `vending` tags in the presetID - in case a more specific preset exists for those things. This fixes a minor annoyance where only matching `key/value` would find the "fast food" preset instead of the "chicken fast food" or "pizza fast food" preset. So now Chick-fil-a has a chicken icon and Sbarro has a pizza icon. 🍕
quincylvania
approved these changes
Jan 15, 2019
Good catch! This was not intentional - I just pushed a fix for this..
|
quincylvania
approved these changes
Jan 15, 2019
|
@bhousel Great! I'd go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the brand suggestion preset generation over to use the new inherit fields feature from #5712 - @quincylvania can you take a look?
This also attempts to include
cuisineandvendingtags in thepresetID- in case a more specific preset exists for those things. This fixes a minor annoyance where by only matchingkey/value, the code would find the "fast food" preset instead of the "chicken fast food" or "pizza fast food" preset.It means that now Chick-fil-a has a chicken icon 🍗 and Sbarro has a pizza icon. 🍕