Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pressing Escape with only one active node in area #5950

Merged
merged 1 commit into from
Feb 24, 2019
Merged

Fix pressing Escape with only one active node in area #5950

merged 1 commit into from
Feb 24, 2019

Conversation

jguthrie100
Copy link
Contributor

Fixes #5941

@jguthrie100
Add exception to isInvalidGeometry algorithm
2490466 
 - An area with just 1 placed node (2 nodes including active, to-be-placed node,
    returns as valid and is picked up by later way.isDegenerate() check
@jguthrie100
Copy link
Contributor Author

press-escape-with-one-node-in-area

@quincylvania quincylvania merged commit bc3bf88 into openstreetmap:master Feb 24, 2019
@quincylvania
Copy link
Collaborator

Thanks, @jguthrie100 👍👍

@quincylvania quincylvania added this to the Next Release milestone Feb 24, 2019
@maxgrossman
Copy link
Collaborator

...yay! Awesome for coming in for the quick bug fix @jguthrie100!

Though I'm still stuck on feeling it is a little weird that some times the graph's childNodes method returns the # of nodes that the way obj has and other times it does not. Could it be that there a more problematic graph-related bug we need to investigate that this relatively innocuous bug has just brought light to.

@quincylvania
Copy link
Collaborator

@bhousel Do you know of any reason childNodes wouldn't return all the nodes?

@bhousel
Copy link
Member

bhousel commented Feb 24, 2019

@bhousel Do you know of any reason childNodes wouldn't return all the nodes?

Maybe it was called on a stale graph? I can check this week..

@quincylvania quincylvania mentioned this pull request Feb 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.14.3
Development

Successfully merging this pull request may close these issues.
4 participants
@jguthrie100 @quincylvania @maxgrossman @bhousel