Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate amenity=dancing_school #6251

Merged
merged 1 commit into from
Apr 28, 2019
Merged

Conversation

westnordost
Copy link
Contributor

Also deprecated in the wiki and a replacement is available, see https://wiki.openstreetmap.org/wiki/Tag%3Aamenity%3Ddancing_school

Also deprecated in the wiki and a replacement is available, see https://wiki.openstreetmap.org/wiki/Tag%3Aamenity%3Ddancing_school
@bhousel
Copy link
Member

bhousel commented Apr 28, 2019

Thanks for all your contributions today @westnordost 👏

@bhousel bhousel merged commit 5f8c51a into openstreetmap:master Apr 28, 2019
@simonpoole
Copy link
Contributor

A facility providing professional dancing instruction may be co-located with a dancing hall, but just as well could be completely separate depending on the audience and scope (for example providing vocational education).

Just because somebody engaged in wiki-fiddling is no reason to jump to conclusions.

@westnordost
Copy link
Contributor Author

Okay, so the concept is that leisure=dance is a "(general purpose) dancing hall" and amenity=dancing_school is, well, a dancing school? And the latter can be within the former?

Then let's revert this and make the dancing school a preset and somebody should clear up the wiki.

@bhousel
Copy link
Member

bhousel commented Apr 29, 2019

Then let's revert this and make the dancing school a preset and

Dance Hall has been a preset since 2016, see #3579 and I followed the recommendation on the wiki at the time.

Dance school has been a preset since 2018, see #4846. The contributor followed the recommendation on the wiki at the time.

I agree that the wiki could use some cleanup, but we don't need to revert anything. We are following the guidelines the best we can, and we don't need multiple presets for Dance Halls - it's totally fine to deprecate the amenity one.

@westnordost
Copy link
Contributor Author

westnordost commented Apr 29, 2019

I think this is about the name. Sure, you may get tuition at a dancing venue, but this doesn't make the dancing venue a dancing school.

For example, a car dealership shop=car may also offer repair services (service:vehicle:car_repair=yes?), but that doesn't make the car dealership an automobile repair shop shop=car_repair. These two are usually quite some different things, at least are referred to differently (as I just did).

Whether this is really about that, I am not sure, because the wiki is not really clear here. But at least it would make sense this way and would be consistent.

Edit: Also in size. Dancing schools may often be only a small-ish room as big as a yoga-room or dojo, while I would imagine that a dancing venue/hall (don't know any) would be a bigger thing.

@matkoniecz
Copy link
Contributor

openstreetmap/id-tagging-schema#373 proposes revert of that PR

@matkoniecz
Copy link
Contributor

openstreetmap/id-tagging-schema#1177 (comment) actually reverts it, I made broken PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants