Imagery index #7428
Merged
Imagery index #7428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove the update_imagery script and steps to run it (this happens at runtime now) - update privacy policy, faq, release notes, readme
|
Pretty excited about this part |
(closes #4977) Before custom sources were assumed tms, now we detect wms and guess 'EPSG:3857' projection This commit also delays selecting the custom source in background_list.js, because creating the background sources is promisified now might not happen until after the UI control is created
quincylvania
approved these changes
Mar 13, 2020
This was referenced Mar 13, 2020
Closed
|
Due to strong push-back from some influential members of the community, I've reverted the changes from this PR for now. I'm also locking conversation in this and #7425 until the best medium for discussing a path forward is determined. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the source of our imagery from ELI to imagery_index.
As followup I'd like to allow iD projects to work with alternate imagery indexes (and preset indexes). But at least now the bulk of the work is done, to switch from "bundled" imagery (which only changes when iD releases happen) to "fetched" imagery (which can be released on different schedule from iD).
closes #7425