Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbundle tagging schema data #8229

Merged
merged 8 commits into from
Dec 7, 2020
Merged

Unbundle tagging schema data #8229

merged 8 commits into from
Dec 7, 2020

Conversation

quincylvania
Copy link
Collaborator

This makes iD load the presets and other tagging data from the npm CDN at runtime, meaning we can update them without doing an iD release.

Since the presets require their own version-specific translations, those strings have been removed from iD's bundled locale files. coreLocalizer has been upgraded to handle multiple sets of locale files.

The name-suggestion-index presets have been temporarily removed for this, but we'll add them back as an external preset expansion pack.

One snag is that iD bundles only the fontawesome icons for the listed presets, so new FA icons can only be added with a new release. We should look into a better solution.

@quincylvania quincylvania added chore-dependency Improvements to one of iD's dependencies data An issue with the data built into iD labels Dec 1, 2020
@quincylvania quincylvania added this to the 2.20.0 milestone Dec 1, 2020
@quincylvania quincylvania self-assigned this Dec 1, 2020
Copy link
Contributor

@pnorman pnorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need an update to the privacy policy to mention that it requests content and transmits PII to the NPM CDN.

@kymckay
Copy link
Collaborator

kymckay commented Dec 2, 2020

@pnorman Could you clarify which PII is being transmit? I couldn't see that in the changes

@quincylvania
Copy link
Collaborator Author

This will need an update to the privacy policy to mention that it requests content and transmits PII to the NPM CDN.

@pnorman Hmm okay, we've already been fetching certain resources there since 2.18.0, but better late than never I suppose.

'nsi_brands': 'https://cdn.jsdelivr.net/npm/name-suggestion-index@4/dist/brands.min.json',
'nsi_filters': 'https://cdn.jsdelivr.net/npm/name-suggestion-index@4/dist/filters.min.json',
'oci_features': 'https://cdn.jsdelivr.net/npm/osm-community-index@2/dist/features.min.json',
'oci_resources': 'https://cdn.jsdelivr.net/npm/osm-community-index@2/dist/resources.min.json',

@ireun
Copy link

ireun commented Jul 26, 2021

It would be great if the openstreetmap/id-tagging-schema could be updated to include newest Translations.

Also that repository seems to be kind of unmaintained, many pull requests are left for a half a year without any notice from the collaborators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore-dependency Improvements to one of iD's dependencies data An issue with the data built into iD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants