-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbundle tagging schema data #8229
Conversation
Update for id-tagging-schema 2.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need an update to the privacy policy to mention that it requests content and transmits PII to the NPM CDN.
@pnorman Could you clarify which PII is being transmit? I couldn't see that in the changes |
@pnorman Hmm okay, we've already been fetching certain resources there since 2.18.0, but better late than never I suppose. iD/modules/core/file_fetcher.js Lines 22 to 25 in de7ab7e
|
It would be great if the openstreetmap/id-tagging-schema could be updated to include newest Translations. Also that repository seems to be kind of unmaintained, many pull requests are left for a half a year without any notice from the collaborators. |
This makes iD load the presets and other tagging data from the npm CDN at runtime, meaning we can update them without doing an iD release.
Since the presets require their own version-specific translations, those strings have been removed from iD's bundled locale files.
coreLocalizer
has been upgraded to handle multiple sets of locale files.The name-suggestion-index presets have been temporarily removed for this, but we'll add them back as an external preset expansion pack.
One snag is that iD bundles only the fontawesome icons for the listed presets, so new FA icons can only be added with a new release. We should look into a better solution.