-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance some horse related search results #413
Comments
I think your suggestions are good, thanks for that. But I also think that at least part of the issue is that we don't consistently use only one of the three possible terms Horseback Riding, Horse Riding and Riding in these presets. I think the search results would be improved if we stuck with one of these options:
Does anything speak against just consistently using the versions with Horse Riding (middle column above)? Since I'm not a native speaker, I don't know whether there exist (subtle) differences or nuances between the different versions… |
AFAIK, it is Horse Riding in British English, Horseback Riding in US English and Horse Racing in both, British and US English (see also wikipedia: horse racing). But I'm not a native English speaker either. Please also note:
In summary, if you want to use the long versions of the names, I would suggest:
Maybe using the British names as aliases in the presets can improve the search results in case someone searches just for "horse" (instead of "horseback"). I don't know. |
For |
Thank you for the clarifications.
My main intention was to use the a single "prefix" for all horse riding related presets, because it would solve at least some of the sorting issues listed above: A partial match on a preset name will otherwise always be preferred over a match of one of the preset terms. Would the following make sense?
|
Some change / enhancement requests for the new table:
|
I’m not an expert at equestrian sports, so I would be happy to defer to someone who is. The article I linked equates arenas with rings, but the two words are different in other sports, hence my hesitation. There probably isn’t a 100% perfect way to accommodate both experts and laypeople, so either way is fine by me. The article also distinguishes round pens from arenas, but it’s unclear to me if OSM does. I’ve seen them both mapped as
(Maybe in some regions, but there’s a lot of room for improvement in North America. I probably skip over dozens of unmapped round pens every week for lack of time.) Preset search results are ranked by edit distance (that is, similarity to the search term) and would only be alphabetized in the event of a tie. |
I admit that this is a problem. But when I looked around the web, I always had the impression that "arena" is used more often than "ring", example page. And I would not make the less used word the main name in iD. (But maybe this was selective perception).
There is a proposal for leisure=practice_pitch which could be used for [round] pens, but it isn't used for any of them yet (in combination wirh |
I've now included the proposed name changes (including the suggestions from #413 (comment)). As far as I can tell, this fixes all the issued listed in the original post, except for the racetrack presets showing up when searching for horseback. I'm not 100% sure why exactly these show up (I would assume because they share enough letters to be classified as a partial match), but fixing that would need to be done in iD's code. |
Thanks.
should actually be "riding stables". It could also be moved to the aliases as "Horseback Riding Stables". What I do not understand is that for en_GB "Horse Riding Stables" was added as an alias, but the preset is still not listed when searching for "riding stables": Why is that? |
Support for searching by an alias was added very recently, after the latest v2.20.4 release: openstreetmap/iD@8796a41. openstreetmap/iD#6139 remains open to track displaying the alias as the name of the matching search result. |
It seems that a lot of Riding Arenas are mapped as Horseback Riding Facilities. This may be because some horse related searches don't list Riding Arenas.
I don't know how the feature search exactly works. Therefore, I list here some horse related search results and explain what I think is missing or is wrong with them and how it can possibly be improved:
horseback riding
search result (en)
What is wrong?
Riding Arena
is missing, see also more general descriptionHow to fix? (assumption)
Horseback Riding Arena
to presets/leisure/pitch/equestrian.json (already contains termshorseback
andriding
but this doesn't seem to be enough to get it listed when searching forhorseback riding
)horse riding
search result (same for en and en-GB)
What is wrong?
Riding Arena
is missing, see also more general descriptionHorse Racing Track
shouldn't be listed here; at least it shouldn't be listed beforeRiding Arena
orHorseback Riding Facility
.How to fix? (assumption)
Horseback Riding Arena
to presets/leisure/pitch/equestrian.json (already contains termshorse
andriding
but this doesn't seem to be enough to get it listed when searching forhorse riding
). (Horseback Riding Arena
has to be translated toHorse Riding Arena
for en-GB.)Horse Racing Track
is listed here, see presets/leisure/track/horse_racing.json. Perhaps adding aliasHorseback Riding Arena
(see point 1) can help to move if belowRiding Arena
, I am not sure.horse
search result
What is wrong?
Riding Arena
is only at 9th position, should rather be listed near or beforeHorseback Riding Facility
How to fix? (assumption)
Horseback Riding Arena
to presets/leisure/pitch/equestrian.json may improve this, I am not sure.horse racing
search result
What is wrong?
Horseback Riding Facility
shouldn't be listed here, but at leastHorce Racing Track
is listed beforeHorseback Riding Facility
, so this may still be accepable.How to fix? (assumption)
horse racing
isn't in presets/leisure/horse_riding.jsonhorseback
search result
What is wrong?
Horse Racing Track
shouldn't be listed hereMotocross
Racetrack shouldn't be listed hereMotorsport
Racetrack shouldn't be listed hereHow to fix? (assumption)
riding
search result
What is wrong?
EDIT / ADDITION
horse stable
search result
What is wrong?
Stable
(presets/building/stable.json) not listed, see also more general descriptionHow to fix? (assumption)
Horse Stable
to presetStable
barn & shed
search result
(similar for shed)
What is wrong?
Stable
(for horses) not listed. It seems that in the US they sometimes call a horse stable "barn" or "shed", see websites: here and hereHow to fix? (assumption)
horse barn
andhorse shed
to presets/building/stable.json, compare presets/building/cowshed.json and presets/building/sty.jsonThe text was updated successfully, but these errors were encountered: