-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide also NSI data in a presets.full.json? #74
Comments
I've looked at https://github.com/osmlab/name-suggestion-index/blob/main/dist/presets/name-suggestions.json which I guess would be the "raw" NSI distribution, however the format is quite a bit different. So if I was to write a new parser for that, I'd need to do some research on that. A few things that I see:
|
You don't have to do that - my plan is to just generate presets for NSI that conform to the id tagging schema once it settles. |
What does that mean? Does this mean that the NSI will become the go-to-place to get the "full" |
☝️ this one |
Ok nice, but then my initial question remains:
It would be more convenient (for me) to have only one file to download that included everything. |
Not presently. As part of making iD more modular, the idea is to be able to support preset packs from multiple sources rather than having everything live in one big file. Though we'll have to see how this works in practice. |
…hey are going to be shipped in the future see openstreetmap/id-tagging-schema#74
Ok I added this functionality (to load presets.jsons + translations if any from several sources) to the osmfeatures library. However I did not release the new version yet in case some more changes to the schema will appear in the next days. I have the impression that the dust did not settle on v2.0.0 yet. |
@westnordost Great. Things are still changing, yes, but now with version control this should be a bit easier to account for. |
Since the commit for 2.0.0, the NSI data seems to be missing from the presets.
If this was deliberate, are you planning to provide an alternative
presets.json
with that data included?The text was updated successfully, but these errors were encountered: