Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide also NSI data in a presets.full.json? #74

Closed
westnordost opened this issue Dec 2, 2020 · 8 comments
Closed

Provide also NSI data in a presets.full.json? #74

westnordost opened this issue Dec 2, 2020 · 8 comments

Comments

@westnordost
Copy link
Contributor

Since the commit for 2.0.0, the NSI data seems to be missing from the presets.

If this was deliberate, are you planning to provide an alternative presets.json with that data included?

@westnordost
Copy link
Contributor Author

westnordost commented Dec 2, 2020

I've looked at https://github.com/osmlab/name-suggestion-index/blob/main/dist/presets/name-suggestions.json which I guess would be the "raw" NSI distribution, however the format is quite a bit different. So if I was to write a new parser for that, I'd need to do some research on that.

A few things that I see:

  • There is no addTags(, removeTags) even though this information is necessary because there is a difference between "full tagging" of a brand and tagging that makes the NSI/iD recognize that it is this or that brand. Without this differenciation I don't really know what to do with that data
  • The imageURL is missing
  • categorization is different than in the presets.json

@bhousel
Copy link
Member

bhousel commented Dec 2, 2020

So if I was to write a new parser for that, I'd need to do some research on that.

You don't have to do that - my plan is to just generate presets for NSI that conform to the id tagging schema once it settles.
osmlab/name-suggestion-index#4718

@westnordost
Copy link
Contributor Author

What does that mean? Does this mean that the NSI will become the go-to-place to get the "full" presets.json? Or does it mean that there will (soon) be a nsi-presets.json in the dist folder in the NSI repository that has the same schema as the id-tagging-schema?

@bhousel
Copy link
Member

bhousel commented Dec 2, 2020

Or does it mean that there will (soon) be a nsi-presets.json in the dist folder in the NSI repository that has the same schema as the id-tagging-schema?

☝️ this one

@westnordost
Copy link
Contributor Author

Ok nice, but then my initial question remains:

are you planning to provide an alternative presets.json with that data included?

It would be more convenient (for me) to have only one file to download that included everything.

@westnordost westnordost changed the title NSI data missing from presets Provide also NSI data in a presets.full.json? Dec 2, 2020
@quincylvania
Copy link
Collaborator

are you planning to provide an alternative presets.json with that data included?

Not presently. As part of making iD more modular, the idea is to be able to support preset packs from multiple sources rather than having everything live in one big file. Though we'll have to see how this works in practice.

westnordost added a commit to streetcomplete/StreetComplete that referenced this issue Dec 3, 2020
@westnordost
Copy link
Contributor Author

Ok I added this functionality (to load presets.jsons + translations if any from several sources) to the osmfeatures library. However I did not release the new version yet in case some more changes to the schema will appear in the next days. I have the impression that the dust did not settle on v2.0.0 yet.

@quincylvania
Copy link
Collaborator

@westnordost Great. Things are still changing, yes, but now with version control this should be a bit easier to account for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants