Update public_bookcase.json - Add more fields

[danieldegroot2]

In general,

• adds generic combo field books (also used on book shops etc.).

For public bookcase,

• adds fields books, direction
• adds moreFields colour, height, support. However, it seems height is already supported on any object, eventhough not all presets need this.
• moves lit from fields to moreFields.

Ignored:

• anything used with booth or building key.
• a few with internet_access(yes/wlan) and/or inscription exist.
• a single fee=yes (58 uses) this one.
• a single width/length, useful for nodes (1 use) this one.
• material (58 uses) is used but also included in public_bookcase:type. This seems somewhat of a tagging issue.
• recycling:books, charity and second_hand are used by WikiProject:CircularEconomy but mostly in France.
• there is also some use of reuse:policy, reuse:books, reuse:facility. It is used by Public bookcase map, see source code.

PS: Made a typo in the first commit saying capacity was added but it is still the same.

[github-actions]

🍱 Preview the tagging presets of this pull request here: https://pr-1001--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

[tyrasd]

Usually, I use the popularity of tag combinations to determine which fields to offer by default and which to include as optional fields. See below for some instances where I noticed that the preset would not match this rule of thumb.

Also, the books field should pobably allow for a multi-selection (see also the inline comment below).

[tyrasd]

I would have said that for public bookcases, it is rather the exception to find only specific types of books. For this reason, I would have put this field to the moreFields section.

[danieldegroot2]

It is already exception they are mapped, let alone such tags being discovered by users, but it is fine to change it.

[tyrasd]

The lit tag seems to be a relatively popular combination (see taginfo: https://taginfo.openstreetmap.org/tags/amenity=public_bookcase#combinations). Why hide it?

[danieldegroot2]

For clarity, it is moved to moreFields. (it is not hidden if people can easily discover it)
I think it is overall more of an exception they are lit, although relatively popular now.
Similarly, I think it is exception people will use a bookcase at night (except in areas with longer nights).
Otherwise I also don't think it is significant property of object itself, like for advertising (only on few ones on public squares).

(Here also it is fine to change it.)

[tyrasd]

The direction tag is not used very commonly on public bookcases. What's the intention behind offering the field by default for these features?

[danieldegroot2]

So it can be more easily discovered.
direction in general is not often used, because it is not directly a object/access type.
However, it is often found on/near barrier and usually only accesible from one side.
It is recommended to add direction to such objects to prevent ambiguity with its position relative to other objects.
(similar to cameras, defibrillators, etc.)

(Here also it is fine to change it.)

[tyrasd]

Thanks for the feedback. I've changed the field type to allow multiple values and tweaked the label to also fit other uses of the tag (e.g. on book shops or libraries). I've also reverted the field "ordering" to match the usage/popularity of the attributes for now.