Add translatable strings for Swimming Pool field #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added translatable strings for Swimming Pool field
|
🍱 Preview the tagging presets of this pull request here: https://pr-1008--ideditor-presets-preview.netlify.app/id/dist/#locale=en. |
|
Hey @tyrasd, would you be able to review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the swimming pool field is only being used for the Swimming Pool preset, however the most common values for
swimming_pool=*are ones that aren't relevant for its use in combination withleisure=swimming_pool(ieyes,no,outdoor,indoor).This PR also adds a preset for
leisure=hot_tuband adds a deprecation rule forleisure=swimming_pool+swimming_pool=hot_tub