Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1016 Create bicycle_wash.json (amenity=bicycle_wash) #1032

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

mcliquid
Copy link
Contributor

Fix for #1016

First attempt to add the new tagging scheme to iD. This is my very first pull request here, so feel free to share what needs to be improved.

The current icon in the PR is from FontAwesome, as I've seen it that way in other PRs, but there would also be a custom icon that would fit better. How to mark this one?
https://wiki.openstreetmap.org/wiki/File:Bicycle_wash.svg

First attempt to add the new tagging scheme to iD
@mcliquid mcliquid marked this pull request as ready for review October 16, 2023 16:43
@tordans
Copy link
Collaborator

tordans commented Oct 16, 2023

@mcliquid ideally ask to add the icon to be added at https://github.com/rapideditor/temaki/issues which makes it easy to integrate here.

@mcliquid
Copy link
Contributor Author

@tordans Thank you! I've added a PR here: rapideditor/temaki#88

@mcliquid
Copy link
Contributor Author

The PR has been merged: rapideditor/temaki#88
Switched icon to temaki version. Anything else open?

@mcliquid
Copy link
Contributor Author

@tyrasd As far as I can see, you need to start the workflows so that they can run through and we can merge that PR, right?

Copy link

🍱 Preview the tagging presets of this pull request here: https://pr-1032--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

@tyrasd
Copy link
Member

tyrasd commented Nov 27, 2023

@mcliquid cool idea. However, I would really prefer if such a previously undocumented and not high usage tag would go through some kind of community vetting process first before it is included in iD's presets. This could be in the form of a wiki tag proposal process, or a reasonably equivalent discussion in the community.

@tyrasd tyrasd added the waitfor-discussion a discussion in the osm community (e.g. a tag proposal) is required before this can be worked on label Nov 27, 2023
@mcliquid
Copy link
Contributor Author

@tyrasd Thanks, Proposal is under way: https://wiki.openstreetmap.org/wiki/Proposal:Bicycle_Wash

I can ping here again when it's voted.

@mcliquid
Copy link
Contributor Author

@tyrasd The Proposal has been accepted: https://wiki.openstreetmap.org/wiki/Proposal:Bicycle_Wash

@mcliquid
Copy link
Contributor Author

@tyrasd Anything else missing?

@tyrasd tyrasd removed the waitfor-discussion a discussion in the osm community (e.g. a tag proposal) is required before this can be worked on label Jan 24, 2024
@tyrasd tyrasd added this to the v6.7 milestone Jan 24, 2024
@tyrasd
Copy link
Member

tyrasd commented Jan 24, 2024

@mcliquid: thank you and no: this PR looks great now. ☺️ I'll merge this very soon, so it can be included with the upcoming release of the tagging presets.

@tyrasd
Copy link
Member

tyrasd commented Jan 24, 2024

PS: it seems like the proposal already brought a bit of traction/visibility to the tag:

@tyrasd tyrasd merged commit f808525 into openstreetmap:main Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants