-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Library Book Return preset #1037
Conversation
a72927c
to
eecc478
Compare
🍱 Preview the tagging presets of this pull request here: https://pr-1037--ideditor-presets-preview.netlify.app/id/dist/#locale=en. |
eecc478
to
4a59f7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Library Book Return" sounds like including desk at library where books are normally returned, while https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dlibrary_dropoff defines it as "A remote dropoff location for a library."
I think @matkoniecz has a valid point here. While library book returns seems to be the correct term for these drop boxes, there could be confusion with in person book returns (example usage). But I think the adjective remote could also be irritating, because these devices are often found just outside or even inside of a particular library building. Would something like Book Returns Drop Box potentially work, @arch0345 ? |
4a59f7e
to
4ec91fa
Compare
I renamed it to 'Book Return Drop Box'. What else is needed in order for this PR to be merged? |
Adds a preset for
amenity=library_dropoff
which was approved back in 2022