Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Library Book Return preset #1037

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

arch0345
Copy link
Contributor

Adds a preset for amenity=library_dropoff which was approved back in 2022

@github-actions
Copy link

🍱 Preview the tagging presets of this pull request here: https://pr-1037--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

Copy link
Contributor

@matkoniecz matkoniecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Library Book Return" sounds like including desk at library where books are normally returned, while https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dlibrary_dropoff defines it as "A remote dropoff location for a library."

@tyrasd
Copy link
Member

tyrasd commented Nov 27, 2023

I think @matkoniecz has a valid point here. While library book returns seems to be the correct term for these drop boxes, there could be confusion with in person book returns (example usage). But I think the adjective remote could also be irritating, because these devices are often found just outside or even inside of a particular library building.

Would something like Book Returns Drop Box potentially work, @arch0345 ?

@tyrasd tyrasd added this to the v6.6 milestone Dec 15, 2023
@tyrasd tyrasd added the waitfor-info something is unclear with the suggestion, more information is needed to evaluate this feature reques label Dec 15, 2023
@tyrasd tyrasd modified the milestones: v6.6, v6.7 Jan 24, 2024
@arch0345
Copy link
Contributor Author

Would something like Book Returns Drop Box potentially work, @arch0345 ?

I renamed it to 'Book Return Drop Box'. What else is needed in order for this PR to be merged?

@tyrasd tyrasd removed the waitfor-info something is unclear with the suggestion, more information is needed to evaluate this feature reques label Feb 5, 2024
@tyrasd tyrasd merged commit 12b257c into openstreetmap:main Feb 5, 2024
5 checks passed
@arch0345 arch0345 deleted the library_return branch February 5, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants