Rename vending=sweets preset
#1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍱 Preview the tagging presets of this pull request here: https://pr-1038--ideditor-presets-preview.netlify.app/id/dist/#locale=en. |
tyrasd
added
new-label
tyrasd
reviewed
Nov 20, 2023
There was a problem hiding this comment.
Hm… vending=snacks does not seem to be documented, nor used very much.
If I'm not mistaken, the "correct" way to map this would be to use vending=food + food=snacks?? I'm very surprised that there is no proper established tag for snack vending machines.
| "vertex" | ||
| ], | ||
| "terms": [ | ||
| "candy", |
There was a problem hiding this comment.
candy and cookie should remain terms of the vending=sweets preset, shouldn't they?
There was a problem hiding this comment.
I wouldn't consider cookies to be sweets/candy. I kept candy as a term since many snack vending machines also sell candy bars.
Also added a preset for `vending=food` + `food=snacks`
tyrasd
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a preset for
vending=snacksCloses #1036