Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Draft Beer" to "Sold Beer Brands" #1047

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

mcliquid
Copy link
Contributor

Copy link

🍱 Preview the tagging presets of this pull request here: https://pr-1047--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

translations need to be contributed via transifex.com
Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

One remark, though: translations are managed and regularly fetched from the platform called transifex. In general, any of your changes in the dist directory would be overridden by the automated build scripts. Because of that, I have now adjusted the respective changes in this PR. See the contributing guide about how to update the translation.

@tyrasd tyrasd merged commit 3249328 into openstreetmap:main Nov 14, 2023
5 checks passed
@tyrasd tyrasd added the new-label changes the name, aliases or terms of a preset label Nov 14, 2023
@mcliquid mcliquid deleted the brewery-data-field branch November 14, 2023 11:45
@mcliquid
Copy link
Contributor Author

Thanks for your comment! I had almost guessed about the translation, but was unsure exactly how it would work. I will be happy to make the changes via transifex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-label changes the name, aliases or terms of a preset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants