-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ref
and railway:track_ref
fields to railway=rail
and =switch
presets
#1083
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM But disclaimer: I know litte about railway-mappging :-).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from a few minor syntax errors (see below), this looks fine for me as well.
Only one question: the ref
field seems to be quite a bit more common on railway=rail objects (see taginfo). What was your reasoning behind putting the ref
field into moreFields
? Are the track numbers usually easier to map?
One more suggestion: As switches only have a single reference number, it would be sufficient to use the generic field for the |
Applied suggestions from code review Co-authored-by: Martin Raifer <martin@raifer.tech>
@tyrasd Yeah, @tordans suggested this and I agree with him:
|
Ok, that makes sense now. 👍 |
🍱 You can preview the tagging presets of this pull request here. |
@tyrasd Well it's not really an essential technical term. You're right, there is no need to overcomplicate, it's still obvious without |
railway=rail
ref=*
(Line Number) andrailway:track_ref=*
(Track Number) fieldsrailway=switch
ref=*
(Switch Number) field