Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add menstrual products #1116

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Conversation

moan0s
Copy link
Contributor

@moan0s moan0s commented Feb 14, 2024

I hope I did this correctly, if not I'm happy to correct!
Key Documentation: https://wiki.openstreetmap.org/wiki/Key:toilets:menstrual_products

@tyrasd
Copy link
Member

tyrasd commented Feb 14, 2024

Hey. Thank you for the suggestion. 👍 The tag was only quite recently introduces, that's why the number of uses is still quite low. I would however say that it would be good to have a field for this tag in the editors already now.

This pull request is however still missing the json file for the field of the new tag: You would have to create a new file in data/fields/toilets/menstrual_products.json and fill in the required details (e.g. a label for the field, the possible options, etc.). You might use the field for the wheelchair tag as a template. You could use something like Free Menstrual Products as a label. I'm currently not quite sure how to properly describe the option for the limited tag value… Maybe something like Limited to Some Stalls could work?!

An alternative would be to add this tag as a checkbox field ("type:" "check") for now and monitor how the tag is going to be used in practice over time.

@moan0s
Copy link
Contributor Author

moan0s commented Feb 14, 2024

Thank you so much for the feedback, I added the required file. I liked the Limited to Some Stalls option and used that and kept the radio type.

Copy link

🍱 You can preview the tagging presets of this pull request here.

@moan0s
Copy link
Contributor Author

moan0s commented Feb 15, 2024

I tried the changes in the preview and toilet:menstrual_products is correctly suggested. On the other hand the values are not whereas toilet:wheelchair works as expected. So there is no dropdown menu to select a value. Is that expected or did I do something wrong?

@tyrasd
Copy link
Member

tyrasd commented Feb 15, 2024

You might have misunderstood how the prerequisiteTag is interacting with a field: here it had prevented the field from being included in the list of suggested additional fields. I've changed that in d18c7cc, and AFAICS it should work properly now.

@tyrasd tyrasd merged commit 9889709 into openstreetmap:main Feb 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants