Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add presets for marsh, swamp and reedbed #113

Closed
wants to merge 1 commit into from

Conversation

Bertware
Copy link
Contributor

Add presets for marsh, swamp and reedbed. This makes it significantly easier to map areas with wetlands as they become easier to find (=easier for new mappers) and they'll be suggested as individual types in the iD editor, meaning you can set them with one click instead of having to define the wetland type over and over. Reedbed is a lesser-used wetland type (5%, 52k tags) but is common, and making it easier to find could boost correct usage as well.

https://wiki.openstreetmap.org/wiki/Tag:wetland%3Dmarsh
https://wiki.openstreetmap.org/wiki/Tag:wetland%3Dswamp
https://wiki.openstreetmap.org/wiki/Tag:wetland%3Dreedbed

Copy link
Collaborator

@mbrzakovic mbrzakovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is justified given that all 3 types are approved and have substantial usage in osm.

I noticed that the list of allowed geometries for these types (and wetland) includes points, while the wiki discourages such usage, and josm only allows areas.
Curious on the reasoning behind this.

@tyrasd
Copy link
Member

tyrasd commented Dec 15, 2021

merged as f47186e (including the geometry type fix proposed by @mbrzakovic above)

@tyrasd tyrasd closed this Dec 15, 2021
@Bertware
Copy link
Contributor Author

Sorry, I completely forgot to fix the geometry, agree with @mbrzakovic that points did not have to be included. Thanks for fixing and merging @tyrasd!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants