Add fields to building=construction preset #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add opening_date and check_date fields to the building=construction preset
mbrzakovic
suggested changes
Nov 10, 2021
| "name", | ||
| "address", | ||
| "opening_date", | ||
| "check_date" |
There was a problem hiding this comment.
Less important, but I am curious in hearing opinions if it would makes sense to also add default building fields: building/levels and height here. I suppose the usage could be unclear, given that it could be interpreted as either planned or current. I didn't manage to find any docs on this, but personally I think it would be beneficial to use these in similar context as check_date (to update them during the construction) in order to track the current state and progress.
There was a problem hiding this comment.
Fine by me if people would use it, I rarely know the values to populate those tags but I imagine there are those who do.
mbrzakovic
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #170
Adds opening_date and check_date fields to the building=construction preset