Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fields for level crossing #194

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Conversation

k-yle
Copy link
Collaborator

@k-yle k-yle commented Jul 10, 2021

Rationale

Every year, hundreds of people die at railway level crossings. Mapping the safety features of railway crossings in OSM would be very valuable. There are already tags to describe the safety features of level crossings, iD just doesn't have a preset for them (crossing:barrier, crossing:bell, crossing:light). These descriptive tags have less usage (36k-88k) compared to the main tag railway=level_crossing (908k).

This PR adds three new fields: crossing:barrier, crossing:bell, crossing:light to the four types of level crossings: railway=level_crossing, railway=crossing, railway=tram_level_crossing, railway=tram_crossing

Before After

@natfoot
Copy link
Contributor

natfoot commented Jul 10, 2021

Looks good

This was referenced Jul 11, 2021
Copy link
Collaborator

@mbrzakovic mbrzakovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, thanks for explanation and this feature.

I just wanted to double check and hear some opinions if these fields are indeed valid for tram crossings (tram_crossing, tram_level_crossing).
I observed partial information on this combination in wiki and very low usage in tag info.
Perhaps we could remove these for now and return them if usage spikes in osm,

@k-yle
Copy link
Collaborator Author

k-yle commented Nov 13, 2021

thanks @mbrzakovic, I've removed these fields from tram_crossing and tram_level_crossing

@tyrasd tyrasd added the enhancement New feature or request label Dec 14, 2021
@tyrasd tyrasd merged commit 754d073 into openstreetmap:main Dec 14, 2021
@k-yle k-yle deleted the level_crossing branch December 3, 2022 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new-field
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants