Add shooting presets #240
Merged
Add shooting presets #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
commented
Sep 26, 2021
|
Can we get some eyes on this pull request? I’m no fan of shooting sports or guns in general, but it’s such an unfortunate coincidence that searching for a shooting range currently brings up the School Building preset. It would be unjustifiable to someone who doesn’t know how presets work. |
|
seems ok to me, thanks @1ec5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added presets for Shooting Range (
icon from FontAwesome.
leisure=pitchsport=shooting), Shooting Range Facility (leisure=sports_centresport=shooting), and Paintball Field (leisure=pitchsport=paintball) to avoid the unfortunate string match reported in #237. All three presets use theA “shooting range facility” contains one or more shooting ranges and can be indoors or outdoors. This type of feature isn’t explicitly mentioned on the wiki, but the general pattern of sports centers containing individual pitches is well established. These facilities are often marketed as shooting clubs or rifle clubs, so there’s some overlap with
club=shooting, but I left that out of this PR for simplicity.Although this wiki page lists
shooting=paintballas a type of shooting range, I created a separate preset forsport=paintballinstead. The latter tag is used several times as often, and paintball is played quite differently than most of the shooting disciplines that would be practiced at a shooting range.Fixes #237.