Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translatable strings for Religion field #263

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Nov 4, 2021

Added translatable strings to the Religion field for the most common documented values of the religion key. This PR includes each value with at least 100 occurrences and some mention on this wiki page. There are many more religion values in use, but the less common values would likely be more difficult for translators to translate. They’ll still be visible in the dropdown, just not translated yet.

Working towards #254.

"benzhu": "Benzhu",
"buddhist": "Buddhist",
"caodaism": "Caodaist",
"chinese_folk": "Chinese Folk",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and “Vietnamese Folk” read a bit awkward. I wonder if the strings should be nouns rather than adjectives; “Chinese Folk Religion” sounds less awkward.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chinese Folk Religion seems far better but I am not a native speaker

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can make an exception for the particular entries that don’t have a natural adjective form.

Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the strings should be nouns rather than adjectives

My first tendency was also pro nouns instead of adjectives, but I'm also not a native speaker. 🙊

I think what we should do is using the same scheme for this field and the denomination field. Does that change anything for this PR? 🤔

@tyrasd tyrasd added the enhancement New feature or request label Dec 10, 2021
@1ec5
Copy link
Contributor Author

1ec5 commented Dec 16, 2021

I think what we should do is using the same scheme for this field and the denomination field. Does that change anything for this PR? 🤔

Denomination will be a much more difficult task, because it’s so open-ended. (My past self from 2010 should’ve campaigned hard to make it a freeform text key similar to operator/operator:wikidata…) I’m unsure which form to use for that field. For some denominations (roman_catholic), the adjective form is more natural, but plenty of other denominations lack an adjective form in the first place (assemblies_of_god, iglesia_ni_cristo). We can get by with a few exceptions in Religion, but Denomination will be all over the place.

@matkoniecz
Copy link
Contributor

@tyrasd Is some extra research/help/review required here? I am not a native speaker but may try recruiting some.

(I am interested in denomination stuff as I plan to use it for streetcomplete/StreetComplete#1737 )

@1ec5
Copy link
Contributor Author

1ec5 commented Aug 9, 2022

Upon reflection, I think we should go with the adjective forms of religions, where available. People sometimes need to coin new religion values. If they see that most of the menu items are -isms, they may perceive a need to include -ism in the raw tag value, even though that hasn’t been the general practice. This consideration is specific to English, which happens to be the language of raw tag values; translators can choose the form most suitable in their respective languages.

Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon reflection, I think we should go with the adjective forms of religions, where available.

Sorry for the delay in the review of this PR. I'm OK with merging it as is, but I do also agree that "Chinese/Vietnamese Folk" sounds a bit strange. It's also not really the adjective form of the religion as far as I understand. I'd therefore tend to make an exception for these entries, and use the full "* Folk Religion" name of these religions instead. Or what do you think @1ec5 ?

@tyrasd tyrasd added new-value and removed enhancement New feature or request labels Sep 26, 2022
@tyrasd tyrasd merged commit b4ffc1d into openstreetmap:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants