Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating cuisines based on commonly used values from taginfo #296

Merged
merged 3 commits into from
Dec 15, 2021

Conversation

andrewharvey
Copy link
Contributor

@andrewharvey andrewharvey commented Dec 14, 2021

@andrewharvey
Copy link
Contributor Author

I think at some point we should sort these alphabetically rather than by date added/popularity, though it can be done later.

@tyrasd
Copy link
Member

tyrasd commented Dec 15, 2021

see #252 (comment)

data/fields/cuisine.json Outdated Show resolved Hide resolved
@tyrasd
Copy link
Member

tyrasd commented Dec 15, 2021

I'm wondering if we should do this a bit more methodological this time…

For example, include everything from https://wiki.openstreetmap.org/wiki/Key:cuisine which has at least a certain amount of usage (say 500 times globally).

I think at some point we should sort these alphabetically rather than by date added/popularity

👍 IMO we could do this right away.

@tyrasd tyrasd added the enhancement New feature or request label Dec 15, 2021
@andrewharvey
Copy link
Contributor Author

For example, include everything from https://wiki.openstreetmap.org/wiki/Key:cuisine which has at least a certain amount of usage (say 500 times globally).

You can, for now I just added those I feel confident in.

@tyrasd tyrasd merged commit 6702966 into openstreetmap:main Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new-value
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants