Add presets for Germany School Types based on isced:level
#331
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "tabWidth": 4, | ||
| "useTabs": false, | ||
| "semi": false, | ||
| "printWidth": 80, | ||
| "proseWrap": "never", | ||
| "bracketSpacing": true, | ||
| "endOfLine": "lf" | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "locationSet": { | ||
| "include": ["de"] | ||
| }, | ||
| "key": "isced:level", | ||
| "type": "combo", | ||
| "label": "Ebene der Bildungseinrichtung", | ||
| "placeholder": "1, 2, 3,…", | ||
| "strings": { | ||
| "options": { | ||
| "1": "Grundschule meist bis Klasse 4", | ||
| "2": "Hauptschule, Real- und Oberschulen, Gesamtschule, Gymnasium bis Klasse 10", | ||
| "3": "Gymnasiale Oberstufe, Berufs(fach)schulen", | ||
| "2;3": "Gymnasium, Gesamtschule mit gymnasialer Oberstufe (Klassen 5-13)" | ||
| } | ||
| }, | ||
| "autoSuggestions": false, | ||
| "customValues": false | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "icon": "temaki-school", | ||
| "locationSet": { | ||
| "include": ["de"] | ||
| }, | ||
| "fields": [ | ||
| "name", | ||
| "isced/level-DE", | ||
| "operator", | ||
| "operator/type", | ||
| "address", | ||
| "grades", | ||
| "website" | ||
| ], | ||
| "moreFields": [ | ||
| "religion", | ||
| "denomination", | ||
| "capacity", | ||
| "charge_fee", | ||
| "email", | ||
| "fax", | ||
| "fee", | ||
| "gnis/feature_id-US", | ||
|
There was a problem hiding this comment. You can safely remove this line and the corresponding lines in the other Germany-only presets. It’s pretty unlikely that both this U.S.-only field and the surrounding Germany-only preset would simultaneously apply to the selected feature. Since the countries aren’t neighbors, it’s extremely unlikely that the user would manage to select a school in both countries at the same time. |
||
| "internet_access", | ||
| "internet_access/ssid", | ||
| "level", | ||
| "phone", | ||
| "polling_station", | ||
| "wheelchair" | ||
| ], | ||
| "geometry": ["area", "point"], | ||
| "terms": ["Grundschule"], | ||
| "tags": { | ||
| "isced:level": "1", | ||
| "amenity": "school" | ||
| }, | ||
| "name": "Grundschule, Schulgelände" | ||
|
There was a problem hiding this comment. This is a weird question, but… are there even obscure English names for these school types? Obviously the German names matter more, but ironically translators for German, Spanish, Russian, etc. would be asked to translate these strings, while there would be no way to translate them into English in Transifex. Or is there a way to mark a string as untranslatable? There was a problem hiding this comment. I hinted at this in the issue description. I do not know any and the bit wiki table does not provide any. Should we maybe have a name here along the lines of
This way, people might be less confused in Transfer. There was a problem hiding this comment. That will be unsightly for any English speakers who have the misfortune of editing in Germany. Leaving it as is would be better. We need a dedicated property for flagging untranslatable names and other strings: ideditor/schema-builder#27. In the meantime, I suppose whoever has administrator access in iD’s Transifex project could manually add that context for these strings. |
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| { | ||
| "icon": "temaki-school", | ||
| "locationSet": { | ||
| "include": ["de"] | ||
| }, | ||
| "fields": [ | ||
| "name", | ||
| "isced/level-DE", | ||
| "operator", | ||
| "operator/type", | ||
| "address", | ||
| "grades", | ||
| "website" | ||
| ], | ||
| "moreFields": [ | ||
| "religion", | ||
| "denomination", | ||
| "capacity", | ||
| "charge_fee", | ||
| "email", | ||
| "fax", | ||
| "fee", | ||
| "gnis/feature_id-US", | ||
| "internet_access", | ||
| "internet_access/ssid", | ||
| "level", | ||
| "phone", | ||
| "polling_station", | ||
| "wheelchair" | ||
| ], | ||
| "geometry": ["area", "point"], | ||
| "terms": [ | ||
| "Hauptschule", | ||
| "Realschule", | ||
| "Oberschule", | ||
| "Gymnasium", | ||
| "Gesamtschule" | ||
| ], | ||
| "tags": { | ||
| "isced:level": "2", | ||
| "amenity": "school" | ||
| }, | ||
| "name": "Schule Sekundarstufe 1, Schulgelände" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "icon": "temaki-school", | ||
| "locationSet": { | ||
| "include": ["de"] | ||
| }, | ||
| "fields": [ | ||
| "name", | ||
| "isced/level-DE", | ||
| "operator", | ||
| "operator/type", | ||
| "address", | ||
| "grades", | ||
| "website" | ||
| ], | ||
| "moreFields": [ | ||
| "religion", | ||
| "denomination", | ||
| "capacity", | ||
| "charge_fee", | ||
| "email", | ||
| "fax", | ||
| "fee", | ||
| "gnis/feature_id-US", | ||
| "internet_access", | ||
| "internet_access/ssid", | ||
| "level", | ||
| "phone", | ||
| "polling_station", | ||
| "wheelchair" | ||
| ], | ||
| "geometry": ["area", "point"], | ||
| "terms": ["Gymnasium", "Gesamtschule", "Gymnasiale Oberstufe"], | ||
| "tags": { | ||
| "isced:level": "2;3", | ||
| "amenity": "school" | ||
| }, | ||
| "name": "Schule mit gymnasialer Oberstufe, Schulgelände" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "icon": "temaki-school", | ||
| "locationSet": { | ||
| "include": ["de"] | ||
| }, | ||
| "fields": [ | ||
| "name", | ||
| "isced/level-DE", | ||
| "operator", | ||
| "operator/type", | ||
| "address", | ||
| "grades", | ||
| "website" | ||
| ], | ||
| "moreFields": [ | ||
| "religion", | ||
| "denomination", | ||
| "capacity", | ||
| "charge_fee", | ||
| "email", | ||
| "fax", | ||
| "fee", | ||
| "gnis/feature_id-US", | ||
| "internet_access", | ||
| "internet_access/ssid", | ||
| "level", | ||
| "phone", | ||
| "polling_station", | ||
| "wheelchair" | ||
| ], | ||
| "geometry": ["area", "point"], | ||
| "terms": ["Gymnasium", "Gesamtschule", "Gymnasiale Oberstufe"], | ||
| "tags": { | ||
| "isced:level": "3", | ||
| "amenity": "school" | ||
| }, | ||
| "name": "Schule Sekundarstufe 2, Schulgelände" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This config file specifies indentation with 4 spaces, but
Maybe your config does not apply properly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be. But there is a separate PR for the config; let's discuss it there. The file is only in this PR until all the other questions are addressed. I will remove it at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, now I saw your linked issue about the Prettier config. So I guess you'll reformat the other files before merging, too?