-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add direction field to benches #342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if this one would be better included as an optional field (in "moreFields"
)? Currently, about 1.65% of benches have the direction tag specified (for comparison, the other fields backrest
, seats
, material
all all well above 10%).
+1 fore moreFields. AFAIK GoMap does not distinguish between fields and moreFields (just lists them all in one list), so this change would not affect the goal of getting the tag in the default-list of GoMap. |
Maybe, is it more customary to have "direction" in fields vs moreFields? This is how I determined where to put it, by looking at a couple of other things that had direction defined as a field. I did not aggregate them, just skimmed a few examples. |
There are no hard rules here. Usually, "fields" are only used for the essential properties of map features. This is because mappers (especially beginners) sometimes feel urged to fill out all fields that are displayed. Now, if the direction of a bench should count as essential or not is of course quite a subjective matter. From my personal experience (and going by the numbers mentioned above), the direction is just not very often mapped for benches, that's why I suggested "moreFields". PS: Looking through the other presets, I can see that there are quite a few more presets where the "direction" could be made optional by using the same argument. |
I've noticed a number of benches with directions already in OSM, but without this set, it's something of a hassle to do while using GoMap.
Alright, well, done that way, as you suggest. |
thanks! |
I've noticed a number of benches with directions already in OSM, but without this set, it's something of a hassle to do while using GoMap.