Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify values for "embassy" tag #343

Merged
merged 3 commits into from
Jan 10, 2022
Merged

specify values for "embassy" tag #343

merged 3 commits into from
Jan 10, 2022

Conversation

tyrasd
Copy link
Member

@tyrasd tyrasd commented Jan 10, 2022

closes #340

I'm not completely sure with some of the labels I used here.
If someone could perhaps proof-read these would be very much appreciated! 😊 I was especially unsure about the following ones:

  • "residence": "Official Residence of an Ambassador" – the wiki describes it as the Official residence of an ambassador or other diplomatic chief of mission.
  • "delegation": "Delegation" – AFAICS this one seems to exclusively (?) for the diplomatic missions of the EU (see wikipedia).
  • "interests_section": "Interests Section"

matkoniecz and others added 2 commits January 8, 2022 13:30
embassy=embassy is an unwanted tagging fueled by iD presets showing top taginfo suggestions

there was confused philosophical discussion about deprecations on tagging mailing list - but of all involved noone considered embassy=embassy as a good idea

see https://lists.openstreetmap.org/pipermail/tagging/2022-January/063459.html
@tyrasd tyrasd added help wanted Extra attention is needed new-value labels Jan 10, 2022
embassy=embassy to embassy=yes (new deprecation)
@ZeLonewolf
Copy link
Contributor

The labels are fine.

However, the tag embassy=yes is useless cruft that should not get added to the database. It provides no information beyond amenity=embassy. It should be deleted unless the mapper specifies a specific type of embassy.

@tyrasd
Copy link
Member Author

tyrasd commented Jan 10, 2022

Thanks.

I thought embassy=yes was useful since it explicitly marks a diplomatic "site" as being an actual "regular" embassy (i.e. not of any of the other possible kinds, e.g. branch, mission, delegation, etc.):

osm wiki for embassy=yes:

Bears a sign labeling it as an embassy and is headed by an ambassador.

A simple omission of the embassy tag would leave the actual kind unspecified, wouldn't it?

@ZeLonewolf
Copy link
Contributor

Okay, fair enough. It looks like the original proposal did intentionally make an embassy=yes, which is still weird but that's OSM for you.

@tyrasd tyrasd merged commit d279c23 into main Jan 10, 2022
@tyrasd tyrasd deleted the embassy-values branch January 10, 2022 16:53
@tyrasd tyrasd removed the help wanted Extra attention is needed label Jan 10, 2022
@Bibi56
Copy link

Bibi56 commented Jan 12, 2022

Okay, fair enough. It looks like the original proposal did intentionally make an embassy=yes, which is still weird but that's OSM for you.

Exactly. embassy=full_range_embassy or whatsoever would have made more sense. It's the residence (or not!) and the chancery and the consular services (or not!).

Tag Value
diplomatic embassy
embassy yes
diplomatic:services:citizen_services no
diplomatic:services:immigrant_visas no
diplomatic:services:non-immigrant_visas no

but Embassy of India - Consular Wing:

Tag Value
diplomatic consulate

To make more fun the usage changed over the years:
The former French embassy is now the French ambassador's residence.
The current French embassy was the French General Consulate.
At that time the French chancery was in another place...

tyrasd added a commit to kjonosm/id-tagging-schema that referenced this pull request Mar 27, 2023
@tyrasd tyrasd mentioned this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use embassy=yes instead of embassy=embassy
4 participants