Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add presets for German bicycle DE:240 #345

Closed

Conversation

tordans
Copy link
Collaborator

@tordans tordans commented Jan 10, 2022

Preview for w59463482


Next steps

  • Review PR
  • Test Way with traffic sign – Example
  • Test adding traffic sign to way
  • Test removing traffic sign from way
  • Test adding preset to way
  • Test removing preset to way
  • Check that it is OK to have the images in the JSON the way they are. Do editors need to pull and bundle them? Do we need a repo to pull those from like the Maki/Temaki repos?

Related to #267.

Commit traffic_sign=DE:240 eeca6f1 is a first take at #267.

Add traffic_sign=DE:240 presets

Let's first see if this makes sense before adding more of those tags.

I looked into the other wiki pages from #267. Adding those would require quite a few unsearchable presets with shared fields/moreFields to get the desired result. Mainly, because there are small changes in the traffic_sign value that have affect on the access values which require a new preset (right?). — Is it a good idea to go down this road further?

- only for Germany, since it's a German traffic sign
- one preset for the tagging in combination with `highway=path`, which is dominant (25k) and one un-searchable for `highway=cycleway` (3k) https://taginfo.openstreetmap.org/tags/?key=traffic_sign&value=DE%3A240#combinations
- the unsearchable uses the same `fields+moreFields` as the main preset
- the `imageUrl` (https://github.com/ideditor/schema-builder/blob/main/schemas/preset.json#L62-L65) is the traffic sign from https://wiki.openstreetmap.org/wiki/DE:Tag:traffic_sign%3DDE:240
- the presets match on the two main tags and add the `addTags` or suggest to do so
- should a mapper switch the preset back to something else, `removeTags` should remove the special tags that the mapper should re-add manually
- the list of `fields+moreFields` are optimized for Germany: name move to moreFields (not commonly present on cycleways), segregated was added, sort order was changed for logical groups
- the cycleway with `highway=path`-preset it still in the cycleway-folder, to keep them together
@tordans tordans force-pushed the german-bicycle-traffic-signs branch from 90fd334 to bea33cf Compare March 17, 2023 16:19
@github-actions
Copy link

🍱 Preview the tagging presets of this pull request here: https://pr-345--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

@tordans
Copy link
Collaborator Author

tordans commented Jul 13, 2024

Closing this now. I don't think that adding traffic signs as presets will work. I will continue working on https://trafficsigns.osm-verkehrswende.org/ instead, soon.

@tordans tordans closed this Jul 13, 2024
@tordans tordans deleted the german-bicycle-traffic-signs branch July 13, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants