Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bin field to vending=excrement_bags #355

Merged
merged 4 commits into from
Jan 17, 2022
Merged

Add bin field to vending=excrement_bags #355

merged 4 commits into from
Jan 17, 2022

Conversation

FloEdelmann
Copy link
Contributor

Many excrement bag dispensers have an attached trash bin, so it makes sense to include it in the preset.

@tyrasd
add further fields
37479e9 
as suggested in https://wiki.openstreetmap.org/wiki/Tag:vending=excrement%20bags and move payment to optional fields
@tyrasd
fix previous commit
e4b0ddc
@tyrasd
move ref to optional fields
d2bfc04 
it is used very rarely on these map features: out of about 30k fewer than 500 have it as of early 2022.
@tyrasd
Copy link
Member

tyrasd commented Jan 17, 2022

Thanks! I've tweaked the preset slightly to also include the fee and operator tags (as suggested on https://wiki.openstreetmap.org/wiki/Tag:vending%3Dexcrement_bags), and added a few fields as optional (moreFields) ones (i.e. the ones which are shown for the "parent" preset for all amenity=vending_machines).

@tyrasd tyrasd merged commit fefa5d7 into openstreetmap:main Jan 17, 2022
@FloEdelmann
Copy link
Contributor Author

Cool, even better!

@FloEdelmann FloEdelmann deleted the patch-1 branch January 17, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
add-field
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FloEdelmann @tyrasd