Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly set parcel_pickup to yes in deprecation fix #365

Closed
wants to merge 1 commit into from

Conversation

riQQ
Copy link

@riQQ riQQ commented Jan 22, 2022

Fixes #364

@tyrasd
Copy link
Member

tyrasd commented Jan 24, 2022

Hey. Thanks for this suggestion. I solved it slightly differently in 609c017. Basically, I only removed the upgrade path of the parcel_mail_in case, which was causing the issue. Your solution would have also worked and would arguably have been an even better solution, because it would have preserved the upgrade path for mail-in-only parcel lockers features. I did however go with the other approach, because adding parcel_pickup=yes is somewhat discouraged by the osm wiki, see also #339 (comment). Since drop-off only parcel lockers are relatively rare, I think this solution is acceptable for the moment.

Ideally, there would be a way to indicate in the deprecated.json that upgrading a tag should explicitly not set a particular tag (e.g. something like this: "replace": {"amenity": "parcel_locker", "parcel_mail_in": "yes", "parcel_pickup": null}), but that would need to be implemented as a separate enhancement of this repository.

//edit: I see that there also exists the possibility to specify a replacement in a tagging presets. This should allow to properly implement a dedicated upgrade path for all 3 kinds of parcel lockers.
//edit2: Sadly, the solution mentioned in my first edit doesn't work here, because there doesn't exist a specific preset for the dropoff-only parcel lockers to replace the old tagging variant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposed fix for parcel locker tagged with deprecated scheme suggests wrong tag value
2 participants