Add more disc golf features #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyrasd
requested changes
Jan 28, 2022
There was a problem hiding this comment.
Thanks for this PR. Seems good in general and quite useful. See a few minor suggestions below.
I'm a bit torn on the par vs. disc_golf:par aspect. Your reasoning seems legit (usage is currently 700 for par vs. 200 for disc_golf:par12), but I think this should at least be first documented on the wiki as an alternative tagging possibility.
Footnotes
Also added `point` to disc golf tee/basket
Just added it here |
tyrasd
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a preset for Disc Golf Basket, Disc Golf Hole, and Disc Golf Tee. I decided to use the
parfield for the Disc Golf Hole preset rather thandisc_golf:paras recommended by the wiki as it looks like the majority (735 vs 199) useparinstead.