Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data/presets/amenity/ticket_validator format #391

Merged
merged 4 commits into from
Feb 7, 2022
Merged

Fix data/presets/amenity/ticket_validator format #391

merged 4 commits into from
Feb 7, 2022

Conversation

quotquot
Copy link
Contributor

@quotquot quotquot commented Feb 5, 2022

data/presets/amenity/ticket_validator is not valid JSON, with trailing commas and a dangling curly bracket. This PR fixes these issues.

@tyrasd tyrasd added the bug Something isn't working label Feb 7, 2022
@tyrasd
Copy link
Member

tyrasd commented Feb 7, 2022

Thanks! FYI: The file was also missing the .json file ending (see 7efb634), that's why the tests didn't catch the issues.

@tyrasd tyrasd merged commit 77b0c31 into openstreetmap:main Feb 7, 2022
@quotquot
Copy link
Contributor Author

Thanks to you and other for this fantastic work.

I found these errors because I have a tool that processes the schema. Besides the errors fixed by the PR, my tool also choked up on emergency/water_reservoir, which has the same tags as emergency/water_tank. In fact, the tags are different in their respective preset files, i.e. data/presets/emergency/water_reservoir.json:

    {
        "emergency": "water_tank",
        "natural": "water",
        "water": "reservoir"
    }

and data/presets/emergency/water_tank.json;

    {
        "emergency": "water_tank",
        "landuse": "reservoir"
    }

but they are the same in dist/presets.json (which my tool uses), both being the latter two-key tags. Is dist/presets.json out of date or is there a weird bug somewhere that sets the wrong tags for emergency/water_reservoir (or am I misunderstanding something)? Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants