Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add name field to beach preset #417

Merged
merged 1 commit into from
May 12, 2022
Merged

Conversation

k-yle
Copy link
Collaborator

@k-yle k-yle commented Mar 8, 2022

It's weird how this preset has the surface tag at the top, instead of name. I've seen multiple mappers accidently add the name into the surface field, because it's the top one.

It's hard to determine how many of these errors have been made, but taginfo alone suggests there are over 1001 that have gone unnoticed. It's also not clear whether these were caused by iD.

Footnotes

  1. https://taginfo.osm.org/search?q=surface%3Dbeach (83), https://taginfo.osm.org/search?q=surface%3Dplage (16), https://taginfo.osm.org/search?q=surface%3Dplaya (32), https://taginfo.osm.org/search?q=surface%3Dпляж (8), https://taginfo.osm.org/search?q=surface%3Dstrand (1)

@tordans
Copy link
Collaborator

tordans commented Mar 8, 2022

I am wondering: From your list of examples …

https://taginfo.osm.org/search?q=surface%3Dbeach (83), https://taginfo.osm.org/search?q=surface%3Dplage (16), https://taginfo.osm.org/search?q=surface%3Dplaya (32), https://taginfo.osm.org/search?q=surface%3Dпляж (8), https://taginfo.osm.org/search?q=surface%3Dstrand (1)

… those don't sound to me like values that should be place in the nave field instead. natural=beach + name=Beach sounds like a miss-use of the name field the same way as it is the wrong value for the surface field.


Another approach could be, to add a translated list of surface values to the preset which suggest the list from the wiki "sand, gravel, pebbles, stones, shells".

AFAIK that would make iD suggest this list primarily and not show the taginfo top-x-list anymore. However, AFAIK it would still allow for custom values for edge cases.


Just for reference: https://taginfo.openstreetmap.org/tags/natural=beach#combinations gives surface as the top combination and name right after. So I don't see any reason not to add it; but still think it will not solve the initial problem.

  • 40 72526.97% | surface=* | 40 725
  • 38 82525.71% | name=* | 38 825
  • 31 19320.66% | surface=sand | 31 193

@k-yle
Copy link
Collaborator Author

k-yle commented Mar 8, 2022

Sorry, to clarify: this PR won't prevent tags like name=Beach or surface=beach or surface=some_other_invalid_value.

The problem that this solves is every other examples in those lists, such as surface=havens_beach and surface=pine_lake_beach. I'm pretty sure that user was trying to add name=Pine Lake Beach, but didn't realize that this is the only preset where the first field isn't the name. When you unfocus that text input, iD automatically snake_cases the surface value (replacing spaces with underscores)

@tyrasd tyrasd merged commit a110429 into openstreetmap:main May 12, 2022
@k-yle k-yle deleted the beach-name branch May 12, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants