Additional fields for crossing=traffic_signals presets
#453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds fields for: * `button_operated` * `traffic_signals:arrow` * `traffic_signals:countdown` * `traffic_signals:minimap` * `traffic_signals:sound` * `traffic_signals:vibration`
|
Thanks! |
1ec5
reviewed
May 14, 2022
arch0345
added a commit
to arch0345/id-tagging-schema
that referenced
this pull request
May 14, 2022
|
It looks like the new fields are not linked correctly. None of them show up in the iD instance on openstreetmap.org nor in version that is published on https://ideditor.org/latest-id/. These are the messages that appear in the console and they are mostly identical for all types of crossings. |
tyrasd
added a commit
that referenced
this pull request
May 27, 2022
tyrasd
added a commit
that referenced
this pull request
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds fields for:
button_operatedtraffic_signals:soundtraffic_signals:vibrationtraffic_signals:arrowtraffic_signals:countdowntraffic_signals:minimapbased on keys listed on this wiki article. I added the latter 3 to
moreFieldssince they're not as commonly used as the former.