Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fields from Main Entrance #491

Merged
merged 2 commits into from
Jun 8, 2022
Merged

Conversation

arch0345
Copy link
Contributor

@arch0345 arch0345 commented Jun 5, 2022

Closes openstreetmap/iD#9148
Removes fields from Main Entrance preset to match with fields in the generic Entrance preset

@kjonosm
Copy link
Contributor

kjonosm commented Jun 6, 2022

@arch0345 Does it make sense to also add the entrance field here, so one can switch easily to a different entrance type if needed?

@arch0345
Copy link
Contributor Author

arch0345 commented Jun 6, 2022

Good point @kjonosm. I removed fields so that it'll use the fields listed in the generic Entrance preset:

"fields": [
"ref",
"entrance",
"door",
"access_simple",
"wheelchair",
"level",
"address"
],

@arch0345 arch0345 changed the title Add more fields to entrance=main Remove fields from Main Entrance Jun 6, 2022
@tyrasd tyrasd merged commit fa3563b into openstreetmap:main Jun 8, 2022
@tyrasd tyrasd added the bug Something isn't working label Jun 8, 2022
@arch0345 arch0345 deleted the entrance branch June 8, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

entrance=main should show address box, like entrance=yes
3 participants