-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Informal Foot Path preset #493
Conversation
I don't know which infrastructure I would tag as informal footpath vs. informal path. IMO the informal key was clear in the sense that it is a "desire path" (Google images). Could you describe your goal, mapper-usecase and add some numbers on tags? |
My goal was to have existing features tagged with An overpass query shows that there are currently around 2K features tagged with this combination, which is significantly less than the 100K tagged with |
{ | ||
"icon": "fas-shoe-prints", | ||
"fields": [ | ||
"surface", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could pull all those values from the main preset (with this {} syntax), right? Same for moreTags. This way both stay in sync.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I see this was stuck in pending state. And now it's merged. Will send it anyways; maybe we will refactor some day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
totally makes sense! I can consolidate the preset fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, at second glance, I think it's probably not a good idea in this case: the informal presets purposefully omit some fields (most notably the name
field, but also others like gnis/feature_id-US
), and show other fields by default (e.g. trail_visibility
/ smoothness
) while hiding some under the "more fields" section (e.g. structure
). This makes it kind of impossible to use the field-inheriting feature.
This PR adds an unsearchable preset for
highway=footway
+informal=yes
. I repurposed the Informal Path preset with the exception of themtb_scale
fields.Also added the
informal
field tomoreFields
in the Foot Path preset