Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Informal Foot Path preset #493

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Conversation

arch0345
Copy link
Contributor

@arch0345 arch0345 commented Jun 8, 2022

This PR adds an unsearchable preset for highway=footway + informal=yes. I repurposed the Informal Path preset with the exception of the mtb_scale fields.

Also added the informal field to moreFields in the Foot Path preset

@tordans
Copy link
Collaborator

tordans commented Jun 9, 2022

I don't know which infrastructure I would tag as informal footpath vs. informal path. IMO the informal key was clear in the sense that it is a "desire path" (Google images).

Could you describe your goal, mapper-usecase and add some numbers on tags?

@arch0345
Copy link
Contributor Author

arch0345 commented Jun 9, 2022

My goal was to have existing features tagged with highway=footway + informal=yes be labeled as 'Informal' instead of just being labelled as a Foot Path. However, I didn't really take into account how this could cause confusion as to which preset to use for these types of paths. I can change this to an unsearchable preset to avoid this.

An overpass query shows that there are currently around 2K features tagged with this combination, which is significantly less than the 100K tagged with highway=path:
image

@tyrasd tyrasd merged commit 6f3354a into openstreetmap:main Jun 13, 2022
{
"icon": "fas-shoe-prints",
"fields": [
"surface",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could pull all those values from the main preset (with this {} syntax), right? Same for moreTags. This way both stay in sync.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I see this was stuck in pending state. And now it's merged. Will send it anyways; maybe we will refactor some day.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally makes sense! I can consolidate the preset fields

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, at second glance, I think it's probably not a good idea in this case: the informal presets purposefully omit some fields (most notably the name field, but also others like gnis/feature_id-US), and show other fields by default (e.g. trail_visibility / smoothness) while hiding some under the "more fields" section (e.g. structure). This makes it kind of impossible to use the field-inheriting feature.

@arch0345 arch0345 deleted the informal-footway branch June 18, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants