Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added highway=emergency_access_point #504

Merged
merged 4 commits into from
Jun 21, 2022
Merged

added highway=emergency_access_point #504

merged 4 commits into from
Jun 21, 2022

Conversation

tiptoptom
Copy link
Contributor

@tiptoptom tiptoptom commented Jun 17, 2022

I tried to make a PR for highway=emergency_access_point. This is my first PR here so I hope, everything is fine. And if not forgive me =)

closes #20

Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thanks for your pull request. It definitely makes sense to include a preset for this feature. 👍

See the comments below for a few tweaks to be made before the preset can be merged into the index.

data/presets/highway/emergency_access_point.json Outdated Show resolved Hide resolved
data/presets/highway/emergency_access_point.json Outdated Show resolved Hide resolved
"terms": [
"Highway Emergency Access Point"
],
"name": "Highway Emergency Access Point"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I think we can find a better name for this one. Especially the word "highway" in there irritates me a bit, since these features are often found on hiking paths. What about Emergency Marker, Emergency Location Marker or Rescue Point (and add the not chosen one as aliases)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But for hiking trails etc. I think emergency=access_point is more intended. highway=emergency_access_point refers I think from the tag to a road.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm… the wiki doesn't mention that highway=emergency_access_point is limited to roadside rescue points. On the contrary, it seems to indicate that off-road rescue points are the main intended purpose behind the tag:

For areas which are hard to access, like woods or waterways, some countries offer a network of emergency access points.

Also, most examples I could find are along hiking paths, see https://overpass-turbo.eu/s/1jv1 to check yourself.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, you may be right. I just wanted to create a demarcation to emergency=access_point …
But that doesn't have to be right now.

data/presets/highway/emergency_access_point.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential adding a preset for highway=emergency_access_point
2 participants