Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more playground presets #543

Merged
merged 8 commits into from
Jul 22, 2022
Merged

Add more playground presets #543

merged 8 commits into from
Jul 22, 2022

Conversation

arch0345
Copy link
Contributor

@arch0345 arch0345 commented Jul 18, 2022

This PR adds presets for:

In addition to this, I added fields for subject and subject:wikidata since the wiki article for playground=map recommends adding these tags. I also changed the icon for the Four Square preset to a more specific icon (maki-pitch -> fas-border-all).

Closes #538, related to #533

@tyrasd
Copy link
Member

tyrasd commented Jul 18, 2022

some recent statistics:

tag object count documentation
playground=activitypanel 289 1
playground=aerialrotator 198
playground=bridge 243 ✔️ 2
playground=climbingwall 760 ✔️
playground=funnel_ball 232 ✔️ note3
playground=map 594 ✔️
playground=sledding 204 ✔️
playground=splash_pad 1,039 ✔️
playground=teenshelter 209 ✔️
playground=trampoline 1,217
playground=tunnel_tube 128
playground=water 692
sport=funnel_ball 232 ✔️
sport=gaga 209 ✔️

Footnotes

  1. ✅ – listed on https://wiki.openstreetmap.org/wiki/Key%3Aplayground

  2. ✔️ – dedicated wiki page

  3. dedicated wiki page, but not listed on https://wiki.openstreetmap.org/wiki/Key%3Aplayground

@arch0345
Copy link
Contributor Author

arch0345 commented Jul 18, 2022

  1. ✔️ – listed on https://wiki.openstreetmap.org/wiki/Key%3Aplayground
  2. ✅ – dedicated wiki page

I think you've got them mixed up, tags with a ✔️ appear to have a dedicated wiki article while ones with a ✅ are only listed on https://wiki.openstreetmap.org/wiki/Key%3Aplayground

I'll add playground=funnel_ball to https://wiki.openstreetmap.org/wiki/Key%3Aplayground

Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

data/presets/playground/funnel_ball.json Show resolved Hide resolved
data/presets/playground/map.json Outdated Show resolved Hide resolved
"tags": {
"playground": "sledding"
},
"name": "Play Sledding Hill"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What’s the difference between a “play” sledding hill and one that’s mapped as a hill with a sport? Is it the size, or the lack of other playground equipment nearby?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say both: examples I found in Germany seem to be smaller than the one you linked and are near playgrounds. For example, this hill is actually inside of a leisure=playground area.

data/presets/playground/trampoline.json Outdated Show resolved Hide resolved
data/presets/playground/map.json Outdated Show resolved Hide resolved
* Use `temaki-compass` icon for `playground=map` as suggested
* Remove `line` geometry from `playground=map`
* Rename `playground=trampoline` preset to just 'Trampoline'
for funnel ball/tetherball
@arch0345
Copy link
Contributor Author

Just added a preset for gaga ball, another game found near playgrounds

@tordans
Copy link
Collaborator

tordans commented Jul 19, 2022

As a follow up, it would be awesome to create separate icons for those new presets. It looks like most are generic or re-used:

file icon
data/presets/leisure/pitch/funnel_ball.json "icon": "maki-pitch"
data/presets/leisure/pitch/gaga.json "icon": "maki-pitch"
data/presets/playground/activitypanel.json "icon": "maki-playground"
data/presets/playground/aerialrotator.json "icon": "maki-playground"
data/presets/playground/bridge.json "icon": "maki-playground"
data/presets/playground/climbingwall.json "icon": "maki-playground"
data/presets/playground/funnel_ball.json "icon": "maki-playground"
data/presets/playground/map.json "icon": "temaki-compass"
data/presets/playground/sledding.json "icon": "maki-playground"
data/presets/playground/splash_pad.json "icon": "maki-playground"
data/presets/playground/teenshelter.json "icon": "maki-playground"
data/presets/playground/tetherball.json "icon": "maki-playground"
data/presets/playground/trampoline.json "icon": "maki-playground"
data/presets/playground/tunnel_tube.json "icon": "maki-playground"
data/presets/playground/water.json "icon": "maki-playground"

Co-authored-by: Martin Raifer <martin@raifer.tech>
@tyrasd tyrasd merged commit 06de1fa into openstreetmap:main Jul 22, 2022
@arch0345 arch0345 deleted the playground branch July 31, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Playground Map preset
4 participants