Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas Station preset: move building field to fields #559

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

arch0345
Copy link
Contributor

@arch0345 arch0345 commented Aug 5, 2022

According to Taginfo, a significant amount of features tagged with amenity=fuel also have a building=* tag (~23%).

data/presets/amenity/fuel.json Outdated Show resolved Hide resolved
Co-authored-by: Martin Raifer <martin@raifer.tech>
tyrasd
tyrasd previously approved these changes Sep 9, 2022
@tyrasd tyrasd dismissed their stale review September 9, 2022 10:36

dismiss because I overlooked that the building_area field sets the tag to yes by default (for fuel stations it should be empty by default, however)

@tyrasd
Copy link
Member

tyrasd commented Sep 9, 2022

Sorry, I overlooked that the building_area field sets the building tag to yes by default for new features. For fuel stations it should remain empty by default, however. I think a new field is needed for this particular case.

@tyrasd
Copy link
Member

tyrasd commented Sep 9, 2022

FYI: In 65f46b5, I've split the building_area field into one which has the default yes value (called building_area_yes) and one which doesn't have that default value.

@tyrasd tyrasd merged commit 0ce90ba into openstreetmap:main Sep 9, 2022
@arch0345 arch0345 deleted the fuel branch September 13, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants