Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update danger_area.json #792

Merged
merged 4 commits into from
Mar 6, 2023
Merged

Update danger_area.json #792

merged 4 commits into from
Mar 6, 2023

Conversation

emersonveenstra
Copy link
Contributor

Clearly specify that this is for military areas only, not a general tag for "something that might be dangerous"

Examples of wrong tagging:

Clearly specify that this is for military areas only, not a general tag for "something that might be dangerous"
@tyrasd tyrasd added new-label changes the name, aliases or terms of a preset considering labels Feb 16, 2023
@tyrasd
Copy link
Member

tyrasd commented Feb 16, 2023

Hm… according to the wiki, the tag is also for "civilian" danger areas like https://osm.org/relation/3311547. But I do agree that the current naming is probably too easily confused with "dangerous" everyday situations. Also, the non-military uses of the tag seem to be the exception (other than the Chernobyl NPP site I only found a few of other examples: https://www.openstreetmap.org/way/383899913, https://www.openstreetmap.org/way/219364702, https://www.openstreetmap.org/way/345511928, non military shooting ranges are a somewhat common pattern, though).

Maybe adding the adjective restricted or prohibited would be an alternative, as that seems to be the most distinguishing property I could identify for such areas: What do you think about Danger Zone, Access Prohibited?

@emersonveenstra
Copy link
Contributor Author

That would work too, i think. Also maybe only offering it on ways and relations, not nodes? The wiki says you can put it on a node, but the examples are all on ways, and most of the incorrect usage is on nodes.

@tyrasd
Copy link
Member

tyrasd commented Feb 16, 2023

not nodes

One approach we recently used in similar situations is to limit the preset to areas, but also add a secondary preset for point geometries which is unsearchable. That way existing data is still displayed correctly and the validator does not falsely show a warning that point geometries would not be allowed (which would be the case if we only removed the point geometry type from the preset).

@emersonveenstra
Copy link
Contributor Author

Okay, i think i did it correctly, based off #776

@tyrasd tyrasd merged commit e1b89ae into openstreetmap:main Mar 6, 2023
@tyrasd
Copy link
Member

tyrasd commented Mar 6, 2023

Thanks @emersonveenstra!

@tyrasd tyrasd removed the considering label Mar 6, 2023
@Woazboat
Copy link

Woazboat commented May 26, 2023

Please add a clarification to the preset description that this tag is only intended for military or weapons/explosive related areas. All the examples on the wiki are at least somewhat military related and I don't believe it was ever intended for non-military use. The Chernobyl exclusion zone is/was operated and enforced by the military, so I don't think that's a good example of non-military use.

The current preset name leads people to use the tag in situations where it's clearly misplaced, such as these areas on whistler mountain where skiing is prohibited:
https://www.openstreetmap.org/way/1174298881/history#map=17/50.06046/-122.96019

Besides, adding landuse=military is always incorrect if it's not a military area.

Non military uses seem to be better covered by https://wiki.openstreetmap.org/wiki/Tag:boundary%3Dhazard which was specifically introduced for that reason https://wiki.openstreetmap.org/wiki/Proposal:Hazard#Rationale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-label changes the name, aliases or terms of a preset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants