Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove postbox:type=community #805

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

kjonosm
Copy link
Contributor

@kjonosm kjonosm commented Mar 4, 2023

Although in current use in Canada, shouldn't postbox:type=community rather be applied to amenity=letter_box instead of amenity=postbox?

@1ec5
Copy link
Contributor

1ec5 commented Mar 4, 2023

Canada’s community mailboxes serve both purposes, so the tagging guidelines currently say to prefer amenity=post_box. There was a discussion about community mailboxes (called cluster mailboxes in the U.S.) on the tagging list back in October with no resolution.

@tyrasd
Copy link
Member

tyrasd commented Mar 5, 2023

Tricky one… As far as I can see, use with amenity=post_box is fine for the "outgoing" part of these community mailbox sites. Not sure whether post_box:type=community would imply that at these locations inbound letter boxes also exists, or whether a mapper is meant to also map a corresponding amenity=letter_box feature alongside.

Now, I'm not so sure anymore whether post_box:type is the right tag for this property, though. As the tag is intended for the physical style, these should probably mapped as post_box:type=pillar, and the fact that they share the space with community/cluster mailboxes should go into a different attribute. For a very similar reason, I omitted the value post_box:type=meter. I guess we should at least be consistent. 🤔

@1ec5
Copy link
Contributor

1ec5 commented Mar 5, 2023

I guess so. But post_box:type is already next to useless in North America, where the definition of pillar could describe such a wide variety of designs. If Canada Post’s community mailboxes are pillars, then pillar would be 99% of all currently tagged postbox types in North America – and that’s after I went on a furious search through the U.S. to find non-pillars back in November. (They’re all of a historic nature.)

Perhaps the post_box:type field could be replaced by post_box:design and post_box:mounting fields in regions where those keys are more meaningful?

@tyrasd tyrasd merged commit 1f60e40 into openstreetmap:main Mar 6, 2023
@tyrasd tyrasd removed the considering label Mar 6, 2023
@1ec5
Copy link
Contributor

1ec5 commented Mar 6, 2023

#808 tracks adding post_box:design and/or model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants