-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preset for man_made=quay #810
Conversation
7a30785
to
ed9c618
Compare
you most likely haven't run |
@tyrasd Yeah, that did it. Thanks. Possible icon submitted here: rapideditor/temaki#83 |
The https://taginfo.openstreetmap.org/tags/man_made%3Dpier#combinations Let me know if that should ride along with this PR. |
Good idea, let's add the |
[[note to self: add rendering rule in iD to render side-markers for quays (like retaining wall)]] |
Done. Could you have a look at the field values I've suggested? Those seem to be the most sensible and well-documented ones. |
The values for |
The wiki is indeed a bit vague there. |
Also referred to in openstreetmap#529.
Icon updated to quay; it was merged in temaki. |
🍱 Preview the tagging presets of this pull request here: https://pr-810--ideditor-presets-preview.netlify.app/id/dist/#locale=en. |
The icon isn't showing up in the preview, but that's expected I think? (This PR depends on a newer temaki icon release.) |
yes, as this is brand new, I need to update temaki to v5.3 on iD before it can show up. |
after upgrading teamki (and a rebuild/redeploy), the preview has the new icon now. |
Yep, there it is. Looks fine to me. 👍 |
If this PR is otherwise acceptable I can see about making an icon for it.
Also referred to in #529.
I'm having some issues running
npm run build
; I get the following:Any idea? That does not seem related to this PR.