Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some popular cuisine values #857

Merged
merged 3 commits into from
Apr 14, 2023
Merged

Conversation

matkoniecz
Copy link
Contributor

@matkoniecz matkoniecz commented Apr 5, 2023

added four that I missed in my mapping

https://taginfo.openstreetmap.org/tags/cuisine=tex-mex#overview - added based on comments below

Added also Ukrainian restaurant and Georgian restaurant as POI types (I hope that noone maps every single restaurant in Italy as Italian restaurant BTW - or do the same based on nationality of owner)

Following look sort-of-reasonable but I was not confident enough to add them

https://taginfo.openstreetmap.org/tags/cuisine=international#overview
https://taginfo.openstreetmap.org/tags/cuisine=barbecue#overview (note that there is also cuisine=grill) - seems to make sense but wiki is not explaining clearly what is the difference between them
https://taginfo.openstreetmap.org/tags/cuisine=arab#overview
https://taginfo.openstreetmap.org/tags/cuisine=bagel#overview
https://taginfo.openstreetmap.org/tags/cuisine=african#overview
https://taginfo.openstreetmap.org/tags/cuisine=caribbean#overview
https://taginfo.openstreetmap.org/tags/cuisine=frozen_yogurt#overview

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

🍱 Preview the tagging presets of this pull request here: https://pr-857--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

@1ec5
Copy link
Contributor

1ec5 commented Apr 6, 2023

https://taginfo.openstreetmap.org/tags/cuisine=barbecue#overview (note that there is also cuisine=grill)

Barbecue overlaps with grilling but isn’t necessarily the same thing. There’s already a preset using this tag. It would make sense for the Cuisine field to display a human-readable value after choosing a cuisine-related preset:

"reference": {
"key": "cuisine",
"value": "barbeque"
},
"name": "Barbeque Restaurant"

https://taginfo.openstreetmap.org/tags/cuisine=tex-mex#overview

Some context as to why Tex-Mex should be distinguished from Mexican cuisine:

https://wiki.openstreetmap.org/wiki/Talk:Key:cuisine#Tex_Mex_food
osmlab/name-suggestion-index#2250

@matkoniecz
Copy link
Contributor Author

matkoniecz commented Apr 6, 2023

For tex-mex I was unsure what would be a good label - I guess that Tex-Mex would work?

Barbecue overlaps with grilling but isn’t necessarily the same thing.

From looking at: https://wiki.openstreetmap.org/wiki/Tag:cuisine%3Dgrill https://wiki.openstreetmap.org/wiki/Tag:cuisine%3Dbarbecue - it seems that barbecue can be about roasting/smoking without grilling, right?

If yes, can you add it there?

both are fairly popular in Poland at least
@1ec5
Copy link
Contributor

1ec5 commented Apr 6, 2023

Correct on both counts.

matkoniecz added a commit to matkoniecz/id-tagging-schema that referenced this pull request Apr 6, 2023
@tyrasd
Copy link
Member

tyrasd commented Apr 14, 2023

@matkoniecz did you want to further amend this PR, or should I merge it as is? I just noticed that, for example, the mentioned value tex-mex (see matkoniecz@bfd8351) is not yet included in the branch of this PR… 🤔

@matkoniecz
Copy link
Contributor Author

Thanks for spotting! It should be ready now, but I will wait for build preview and test is everything working.

Copy link
Contributor Author

@matkoniecz matkoniecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work, as far as I can see

@tyrasd tyrasd merged commit 2fce8f9 into openstreetmap:main Apr 14, 2023
@matkoniecz matkoniecz deleted the patch-6 branch April 14, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants