-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add some popular cuisine values #857
Conversation
🍱 Preview the tagging presets of this pull request here: https://pr-857--ideditor-presets-preview.netlify.app/id/dist/#locale=en. |
Barbecue overlaps with grilling but isn’t necessarily the same thing. There’s already a preset using this tag. It would make sense for the Cuisine field to display a human-readable value after choosing a cuisine-related preset: id-tagging-schema/data/presets/amenity/restaurant/barbeque.json Lines 24 to 28 in 39af400
Some context as to why Tex-Mex should be distinguished from Mexican cuisine: https://wiki.openstreetmap.org/wiki/Talk:Key:cuisine#Tex_Mex_food |
For
From looking at: https://wiki.openstreetmap.org/wiki/Tag:cuisine%3Dgrill https://wiki.openstreetmap.org/wiki/Tag:cuisine%3Dbarbecue - it seems that barbecue can be about roasting/smoking without grilling, right? If yes, can you add it there? |
both are fairly popular in Poland at least
Correct on both counts. |
based on 1ec5 cooment in openstreetmap#857 (comment)
@matkoniecz did you want to further amend this PR, or should I merge it as is? I just noticed that, for example, the mentioned value |
based on 1ec5 comment in openstreetmap#857 (comment)
Thanks for spotting! It should be ready now, but I will wait for build preview and test is everything working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to work, as far as I can see
added four that I missed in my mapping
https://taginfo.openstreetmap.org/tags/cuisine=tex-mex#overview - added based on comments below
Added also Ukrainian restaurant and Georgian restaurant as POI types (I hope that noone maps every single restaurant in Italy as Italian restaurant BTW - or do the same based on nationality of owner)
Following look sort-of-reasonable but I was not confident enough to add them
https://taginfo.openstreetmap.org/tags/cuisine=international#overview
https://taginfo.openstreetmap.org/tags/cuisine=barbecue#overview (note that there is also
cuisine=grill
) - seems to make sense but wiki is not explaining clearly what is the difference between themhttps://taginfo.openstreetmap.org/tags/cuisine=arab#overview
https://taginfo.openstreetmap.org/tags/cuisine=bagel#overview
https://taginfo.openstreetmap.org/tags/cuisine=african#overview
https://taginfo.openstreetmap.org/tags/cuisine=caribbean#overview
https://taginfo.openstreetmap.org/tags/cuisine=frozen_yogurt#overview