Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop assuming that all shop=organic are supermarkets #884

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

matkoniecz
Copy link
Contributor

@matkoniecz matkoniecz commented Apr 23, 2023

also, some may be organic=yes so even migrating to shop=yes is not viable - this requires human review

@github-actions
Copy link

🍱 Preview the tagging presets of this pull request here: https://pr-884--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

@Hufkratzer
Copy link
Contributor

Another alternative would probably be shop=convenience + organic=yes/only. Maybe iD can be enhanced to allow the user to select from two or more alternatives. This could also be used for other tags, e.g. for sport=diving, which could be scuba_diving or cliff_diving.

@tyrasd
Copy link
Member

tyrasd commented Apr 24, 2023

Agree that the current tag upgrade is not general applicable. Other examples for shop types where shop=organic might have been used include shop=herbalist, shop=cosmetics, etc. ~ Ideally we'd need a more interactive deprecation resolution process where users have to choose from a list of possible cases or values. But as that is not currently implemented, I think it is fine to just drop the rule for not and let other QA tools take care of this tag.

some may be organic=yes

While this is true in a strict sense, it is IMO reasonable to assume that a user would not have chosen shop=organic as a tag for a shop which does not have a very strong focus on organic products, i.e. organic=yes would not be fitting well in such cases.

@tyrasd tyrasd merged commit 064a820 into openstreetmap:main Apr 24, 2023
@tyrasd tyrasd added the bug Something isn't working label Apr 24, 2023
@matkoniecz matkoniecz deleted the patch-2 branch April 24, 2023 14:09
@matkoniecz
Copy link
Contributor Author

While this is true in a strict sense, it is IMO reasonable to assume that a user would not have chosen shop=organic as a tag for a shop which not have a very strong focus on organic products, i.e. organic=yes would not be fitting well in such cases.

though organic=only is extremely strong

(but with such interpretation migration to shop=yes organic=only would be viable)

@tyrasd
Copy link
Member

tyrasd commented Apr 24, 2023

I always read the wiki that organic=only does not mean that literally only organic products are offered:

All or almost all of the products the shop or restaurant offers are organic. These institutions normally promote themself as "organic"

(highlights by me)

shop=yes organic=only would be viable

Sure, but I would argue that such a tag change would only "hide" the underlying data quality problem we have with this tag: We still don't know which shop type this is and in general some manual research is needed to fix that. Basically, the tag deprecation / upgrade rules here are just not a good place for this type of data quality issue.

@matkoniecz
Copy link
Contributor Author

matkoniecz commented Apr 24, 2023

would only "hide" the underlying data quality problem we have with this tag: We still don't know which shop type this is

shop=yes communicates exactly this (and triggers complaints/special support in few tools like JOSM/StreetComplete/good part of Osmose that copied JOSM errors and shows in iD as underspecified)

while shop=organic shows like thousands of other ATYL shop types (many of them valid!)

@tyrasd
Copy link
Member

tyrasd commented Apr 24, 2023

ok, good point. Let's change it to shop=yes then 👍

//edit: done in 0a8c721

tyrasd added a commit that referenced this pull request Apr 24, 2023
to make it explicit that the shop type is actually unknown and picked up by further quality assurance tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deprecating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants