-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Warning Sign presets #928
base: main
Are you sure you want to change the base?
Conversation
Also added fields for `hazard`, `curve`, `curves`, `hazard:animal`, and changed the name for the `military=danger_area` preset
🍱 Preview the tagging presets of this pull request here: https://pr-928--ideditor-presets-preview.netlify.app/id/dist/#locale=en. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preset names should also be localizable string options for the Traffic Sign field.
These presets understandably focus on the generic values, which apply internationally. But we should probably also add presets for each country’s standard warning signs that set traffic_sign
to a sign code; otherwise, we might inadvertently nudge mappers to replace the specific values with a generic value that has a nice icon, resulting in dataloss.
Related discussion: osmlab/name-suggestion-index#8225 |
I think this is a very real possibility in some regions, such as Central Europe and Scandinavia, where |
I'll separate addition of |
This PR adds presets for both values of
hazard=*
listed in the approved proposal as well as some of the top values with an article on the wiki listed on Taginfo.Adds presets for:
(moved to Add Hazardous Area preset #952)boundary=hazard
traffic_sign=hazard
hazard=animal_crossing
hazard=bump
hazard=children
hazard=curve
hazard=curves
hazard=cyclists
hazard=dangerous_junction
hazard=dip
hazard=emergency_vehicles
hazard=falling_rocks
hazard=flooding
hazard=fog
hazard=ground_clearance
hazard=horse_riders
hazard=ice
hazard=landslide
hazard=loose_gravel
hazard=pedestrians
hazard=queues_likely
hazard=road_narrows
hazard=roundabout
hazard=school_zone
hazard=slippery
hazard=traffic_signals
hazard=turn
hazard=turns
Adds fields for:
curve=*
curves=*
hazard=*
hazard:animal=*
Also changed the name for the(moved to #952)military=danger_area
preset to "Military Danger Area"