Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Warning Sign presets #928

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

arch0345
Copy link
Contributor

@arch0345 arch0345 commented Jun 20, 2023

Also added fields for `hazard`, `curve`, `curves`, `hazard:animal`, and changed the name for the `military=danger_area` preset
@github-actions
Copy link

🍱 Preview the tagging presets of this pull request here: https://pr-928--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preset names should also be localizable string options for the Traffic Sign field.

These presets understandably focus on the generic values, which apply internationally. But we should probably also add presets for each country’s standard warning signs that set traffic_sign to a sign code; otherwise, we might inadvertently nudge mappers to replace the specific values with a generic value that has a nice icon, resulting in dataloss.

data/presets/traffic_sign/hazard/dangerous_junction.json Outdated Show resolved Hide resolved
data/presets/traffic_sign/hazard.json Show resolved Hide resolved
data/presets/traffic_sign/hazard/turn.json Show resolved Hide resolved
data/presets/traffic_sign/hazard/turns.json Show resolved Hide resolved
data/presets/traffic_sign/hazard/curves.json Show resolved Hide resolved
data/fields/curve.json Show resolved Hide resolved
data/fields/hazard/animal.json Show resolved Hide resolved
@Dimitar5555
Copy link
Contributor

But we should probably also add presets for each country’s standard warning signs that set traffic_sign to a sign code; otherwise, we might inadvertently nudge mappers to replace the specific values with a generic value that has a nice icon, resulting in dataloss.

Related discussion: osmlab/name-suggestion-index#8225

@1ec5
Copy link
Contributor

1ec5 commented Jun 23, 2023

These presets understandably focus on the generic values, which apply internationally. But we should probably also add presets for each country’s standard warning signs that set traffic_sign to a sign code; otherwise, we might inadvertently nudge mappers to replace the specific values with a generic value that has a nice icon, resulting in dataloss.

I think this is a very real possibility in some regions, such as Central Europe and Scandinavia, where traffic_sign has been mapped to great detail. At the same time, the code-based traffic_sign syntax as documented on the wiki is unsuitable for proper editor support. An alternative syntax is in use regionally that would be much more amenable to software support, but the wiki doesn’t really acknowledge this alternative: #11 (comment).

@arch0345
Copy link
Contributor Author

arch0345 commented Jul 7, 2023

These presets understandably focus on the generic values, which apply internationally. But we should probably also add presets for each country’s standard warning signs that set traffic_sign to a sign code; otherwise, we might inadvertently nudge mappers to replace the specific values with a generic value that has a nice icon, resulting in dataloss.

I'll separate addition of boundary=hazard into its own PR so that #916 can be resolved before this issue is addressed.

@arch0345 arch0345 changed the title Add Hazardous Area/Warning Sign presets Add Warning Sign presets Jul 7, 2023
@arch0345 arch0345 marked this pull request as draft July 7, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants