Create tagging schema for "Barangay Hall" #932
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add term "barangay."
Create tagging schema for "Barangay Hall". A "barangay" in the Philippines is the smallest administrative government unit. According to [taginfo](https://taginfo.openstreetmap.org/tags/townhall%3Atype=barangay#overview), "barangay" is the third most used value for `townhall:type`, and one of the most popular POI added by mappers from the Philippines. I'm new to adding id tagging schemas, so please be gentle with me. :) Feedback is welcome!
|
🍱 Preview the tagging presets of this pull request here: https://pr-932--ideditor-presets-preview.netlify.app/id/dist/#locale=en. |
tyrasd
previously requested changes
Jun 23, 2023
There was a problem hiding this comment.
Hi. Thanks for this suggestion. It looks quite good already, only a few minor changes would be required: As this is a regional preset, the file name should have a suffix indicating the region it is valid for (i.e. data/…/barangay-PH.json). A few further comments are below:
tyrasd
reviewed
Jun 23, 2023
|
ah, one last suggestion: we could split up the "tags": {
"amenity": "townhall",
"townhall:type": "barangay"
},
"addTags": {
"amenity": "townhall",
"townhall:type": "barangay",
"admin_level": "10"
},This would have the benefit that if the |
Remove "barangay" from the term section.
Incorporate recommended changes by reviewers, and additional updates: * remove icon * add "barrio hall" in terms section
Restore a comma I accidentally removed earlier.
remove extra space Co-authored-by: Martin Raifer <martin@raifer.tech>
Remove superfluous "barangay hall" from terms section
Amend reference to amenity=townhall Co-authored-by: Martin Raifer <martin@raifer.tech>
govvin
commented
Jun 23, 2023
Revise tag section , and include "addTags"
|
Thank you! This has now been merged as 699e10f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create tagging schema for "Barangay Hall".
A "barangay" in the Philippines is the smallest administrative government unit.
According to taginfo, "barangay" is the third most used value for
townhall:type, and one of the most popular POI added by mappers from the Philippines.I'm new to adding id tagging schemas, so please be gentle with me. :) Feedback is welcome!