preset traffic_sign=maxspeed: Use direction icon same as other traffic_sign presets
#968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍱 Preview the tagging presets of this pull request here: https://pr-968--ideditor-presets-preview.netlify.app/id/dist/#locale=en. |
tyrasd
approved these changes
Aug 3, 2023
|
yeah, the icon was like that from the very first version of the preset in iD (see openstreetmap/iD@ |
tyrasd
added a commit
that referenced
this pull request
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preset for
traffic_sign=maxspeedwas the only one in the traffic_sign preset list that used the maki square icon, which is the default "no icon" icon (at least in GoMap).This PR changes the icon to use
fas-directionswhich is what the other generic icons use.FYI, the square Icon is on the maxspeed preset since the start of this repo.
Previous: