Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translatable strings to "marker" field #973

Closed
wants to merge 4 commits into from

Conversation

kjonosm
Copy link
Contributor

@kjonosm kjonosm commented Aug 8, 2023

No description provided.

@github-actions
Copy link

🍱 Preview the tagging presets of this pull request here: https://pr-973--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

@tyrasd
Copy link
Member

tyrasd commented Aug 10, 2023

I think at least some of the value labels are not really intuitive… for example Aerial was not quite clear to me without reading the wiki page. It could be a good idea to use the title/description syntax here, to add some additional information to these values:

        
        "options": {
            "aerial": {
                "title": "Aerial",
                "description": "Designed to be seen by aerial inspection"
            },
            

What do you think?

@kjonosm
Copy link
Contributor Author

kjonosm commented Aug 12, 2023

@tyrasd
I added short descriptions based on OSM wiki.
Feel free to adjust the wording...

data/fields/marker.json Show resolved Hide resolved
data/fields/marker.json Show resolved Hide resolved
@1ec5
Copy link
Contributor

1ec5 commented Aug 12, 2023

I guess it’s fine to omit marker=paddle. As far as we know so far, it’s only being used in one country, although in reality it’s being used in very large numbers.

@tyrasd
Copy link
Member

tyrasd commented Aug 13, 2023

merged as c0bfb28

@tyrasd tyrasd closed this Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants