Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert the "Remove Java Plugin Framework" commits in 0.49.0, to allow external plugins to be loaded in the usual manner #141

Merged
merged 3 commits into from
Dec 2, 2023
Merged

Revert the "Remove Java Plugin Framework" commits in 0.49.0, to allow external plugins to be loaded in the usual manner #141

merged 3 commits into from
Dec 2, 2023

Conversation

alfh
Copy link
Contributor

@alfh alfh commented Nov 26, 2023

This adds back the support for loading plugins via JPF, where the main case is to be able to load plugins without having to modify the osmosis launch script.

We should add back this JPF support now, and then consider if it should be removed in a later release, but then with instructions on how external plugins should be added.

The last commit containing just whitespace fixes you can leave out if you want to.

alfh added 3 commits November 22, 2023 18:38
@alfh
Revert "Remove Java Plugin Framework core plugin file"
2a446f6 
This reverts commit 0db10a1.
@alfh
Revert "Remove Java Plugin Framework"
9130aae 
This reverts the main part of commit 95a380b,
i.e. all of the Java changes are reverted.

Got conflict when reverting the whole commit, so I had to add
the dependency towards JPF to the osmosis-core/build.gradle file
manually.
@alfh
Remove whitespace at end of lines in JPF related files
2618858
@alfh alfh mentioned this pull request Nov 26, 2023
Closed
@alfh
Copy link
Contributor Author

alfh commented Nov 26, 2023

THis is a fix for #140

treee111
treee111 approved these changes Nov 28, 2023
View reviewed changes
Copy link

@treee111 treee111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR @alfh! 👍
It works for me with this branch.
The mapwriter plugin is found again and used to write .map files.

@brettch would be happy to see this merged and a new version to be created 💯
thank you in advance!

@brettch brettch merged commit 518de5d into openstreetmap:main Dec 2, 2023
1 check passed
@treee111 treee111 mentioned this pull request Dec 3, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treee111 treee111 treee111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alfh @treee111 @brettch