Code consolidation and refactoring #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 24, 2020 09:17
…lass to handle common functionality
|
Thank you Michael, this looks good! I’ll leave this PR open for ~1 week in case anyone has any input, and then merge if there are no objections. |
|
No objections, tests pass, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to consolidate some common functionality found in the XML Readers in the osmosis-xml package and some common functionality found in the osmosis-replication package.
In the osmosis-replication package a lot of the classes were retrieving the working directory as an input option for the factory objects. This functionality is consolidated into a single class file "WorkingTaskManagerFactory" and so now those classes simple extend from the common class and don't need to retrieve the working directory.
In the osmosis-xml package each XML Reader was reading the input XML in the same way, and so all that code is consolidated into the "BaseXMLReader" class.