Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade to webpack5 #3303

Merged
merged 5 commits into from
Jan 25, 2024
Merged

build: upgrade to webpack5 #3303

merged 5 commits into from
Jan 25, 2024

Conversation

bytemain
Copy link
Member

Types

  • 🎉 New Features

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1894b9c) 57.77% compared to head (1027b26) 57.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3303      +/-   ##
==========================================
- Coverage   57.77%   57.76%   -0.01%     
==========================================
  Files        1357     1357              
  Lines       85003    85004       +1     
  Branches    17642    17643       +1     
==========================================
- Hits        49111    49105       -6     
- Misses      32623    32629       +6     
- Partials     3269     3270       +1     
Flag Coverage Δ
jsdom 52.64% <50.00%> (-0.01%) ⬇️
node 17.16% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytemain
Copy link
Member Author

bytemain commented Jan 25, 2024

packages/components/webpack.config.js Outdated Show resolved Hide resolved
Copy link
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bytemain bytemain merged commit e36e4de into main Jan 25, 2024
11 checks passed
@bytemain bytemain deleted the feat/webpack5 branch January 25, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants